{bio}[foss/2023a] ctffind5 v5.0.2#20669
Conversation
| sources = [{ | ||
| 'download_filename': '%s.tar.gz' % local_commit, | ||
| 'filename': 'cisTEM-ctffind5-%s.tar.gz' % local_commit[:7], | ||
| 'git_config': { | ||
| 'url': 'https://github.com/timothygrant80', | ||
| 'repo_name': 'cisTEM', | ||
| 'commit': local_commit, | ||
| 'keep_git_dir': True, | ||
| } | ||
| }] |
There was a problem hiding this comment.
Hi @ThomasHoffmann77
this recipe is a piece of work. Congratulation - it was not an easy one.
About the source, can it work with an approach similar to the following?
source_urls = ['https://github.com/lh3/bwa/archive']
sources = [{'download_filename': '%s.tar.gz' % local_commit, 'filename': SOURCE_TAR_GZ}]
checksums = ['be460d6e13ddf34896aafae00bad71e05a0b9f7e23490eeeca8ad257065f5e60']
In this way we can include the checksum in the recipe and help with the reproducibility.
There was a problem hiding this comment.
@kErica the configure script makes use of "git branch" and similar in order to inject the branch name and version and therefore requires the .git directory from the git_config checkout.
|
Test report by @boegel |
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2154506578 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2154541837 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Going in, thanks @ThomasHoffmann77! |
(created using
eb --new-pr)