Skip to content

add --disable-htmlpages to recent FFmpeg easyconfigs#20686

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
bedroge:ffmpeg_disable_htmlpages
Jun 4, 2024
Merged

add --disable-htmlpages to recent FFmpeg easyconfigs#20686
verdurin merged 1 commit intoeasybuilders:developfrom
bedroge:ffmpeg_disable_htmlpages

Conversation

@bedroge
Copy link
Copy Markdown
Contributor

@bedroge bedroge commented May 30, 2024

Building those pages apparently requires texinfo, as I ran into the following issue:

GENTEXI doc/avoptions_format.texi
GENTEXI doc/avoptions_codec.texi
HTML    doc/ffmpeg.html
makeinfo: error parsing ./doc/t2h.pm: Undefined subroutine &Texinfo::Config::set_from_init_file called at ./doc/t2h.pm line 24.
make: *** [doc/Makefile:70: doc/ffmpeg.html] Error 1

A texinfo package (version 7.1) is actually available on my system, but it looks like that specific version is causing issues:
https://groups.google.com/g/linux.debian.bugs.dist/c/1f_eeuQd_2U

Instead of adding texinfo as a (heavy) build/OS dependency, this PR adds a --disable-htmlpages flag to recent versions, which will not build these pages.

@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented May 31, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 31, 2024

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=20686 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20686 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13602

Test results coming soon (I hope)...

Details

- notification for comment with ID 2141551234 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 31, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d09be7a20cb9c691f4df73e39645d4cb for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented May 31, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 31, 2024

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20686 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20686 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4254

Test results coming soon (I hope)...

Details

- notification for comment with ID 2141609428 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 31, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/5119b2081336654ec42fab3baf4a9216 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 4, 2024

Test report by @verdurin
SUCCESS
Build succeeded for 10 out of 10 (4 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/e98c40b205042b7b5e40eba2f6e0c36c for a full test report.

verdurin
verdurin approved these changes Jun 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin added this to the release after 4.9.1 milestone Jun 4, 2024
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jun 4, 2024

Going in, thanks @bedroge!

@verdurin verdurin merged commit b962b77 into easybuilders:develop Jun 4, 2024
@bedroge bedroge deleted the ffmpeg_disable_htmlpages branch June 4, 2024 17:49
@bedroge bedroge mentioned this pull request Jun 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@bedroge @boegelbot @verdurin