Skip to content

remove duplicate crates from easyconfig for timm-0.9.7#20687

Merged
Micket merged 1 commit intoeasybuilders:developfrom
thielemans:patch-1
Jun 7, 2024
Merged

remove duplicate crates from easyconfig for timm-0.9.7#20687
Micket merged 1 commit intoeasybuilders:developfrom
thielemans:patch-1

Conversation

@thielemans
Copy link
Copy Markdown
Contributor

@thielemans thielemans commented May 30, 2024

Removed all crate duplicates as they would trigger extraction errors. They could not be successfully extracted (a second time) on eb 4.9.1.

@thielemans
Removed timm-0.9.7-foss-2022a-CUDA-11.7.0.eb crate duplicates
c136ea6 
Removed all crate duplicates as they would trigger extraction errors. They could not be succesfully extracted (a second time) on eb 4.9.1.
Micket
Micket approved these changes May 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (i wonder why safetensor is included as an extension here, we have that as it's own easyconfig as well)

@Micket Micket added the bug fix label May 30, 2024
@Micket Micket added this to the release after 4.9.1 milestone May 30, 2024
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 7, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 7, 2024

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20687 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20687 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4323

Test results coming soon (I hope)...

Details

- notification for comment with ID 2155228933 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 7, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/617f7cb9d8dbdd4538ec90a41a66143d for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 7, 2024

Going in, thanks @thielemans!

@Micket Micket merged commit c820374 into easybuilders:develop Jun 7, 2024
@boegel boegel changed the title Removed timm-0.9.7-foss-2022a-CUDA-11.7.0.eb crate duplicates remove duplicate crates from easyconfig for timm-0.9.7 Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@thielemans @Micket @boegelbot