Skip to content

add 'pic' flag to IML#20789

Merged
smoors merged 3 commits intoeasybuilders:developfrom
PetrKralCZ:20240610152634_new_pr_IML105
Jun 11, 2024
Merged

add 'pic' flag to IML#20789
smoors merged 3 commits intoeasybuilders:developfrom
PetrKralCZ:20240610152634_new_pr_IML105

Conversation

@PetrKralCZ
Copy link
Copy Markdown
Collaborator

@PetrKralCZ PetrKralCZ commented Jun 10, 2024 •
edited by smoors
Loading

(created using eb --new-pr)

It is needed for other easyconfig for a static library. When the flag is not used, the following error can occur:

libiml.a(libiml_la-basisop.o): relocation ​​​​​​​​​​​​​​​​R_X86_64_32 against `.rodata.str1.1'
can not be used when making a shared object; recompile with -fPIC

@PetrKralCZ PetrKralCZ mentioned this pull request Jun 10, 2024
Closed
2 tasks
@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Jun 10, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 10, 2024

@PetrKralCZ: Request for testing this PR well received on login1

PR test command 'EB_PR=20789 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20789 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13700

Test results coming soon (I hope)...

Details

- notification for comment with ID 2158430489 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 10, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6eb0fa11bfd2b988294b5fb0231f6c05 for a full test report.

@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Jun 10, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 10, 2024

@PetrKralCZ: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20789 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20789 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4351

Test results coming soon (I hope)...

Details

- notification for comment with ID 2158446306 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 10, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/640a3cc9a5d39d0fdfc17a2b3c0c1e66 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 10, 2024

@PetrKralCZ can you add in the description why this is needed?

@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Jun 11, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 11, 2024

@PetrKralCZ: Request for testing this PR well received on login1

PR test command 'EB_PR=20789 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20789 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13711

Test results coming soon (I hope)...

Details

- notification for comment with ID 2159899145 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 11, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e2d368027ef67e7e56f7cd5e31756aec for a full test report.

@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Jun 11, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 11, 2024

@PetrKralCZ: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20789 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20789 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4360

Test results coming soon (I hope)...

Details

- notification for comment with ID 2159958920 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 11, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/2e875b3ec846623db37357c51ae6db6e for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 11, 2024

@PetrKralCZ sorry for the confusion, i meant in the description of this PR, not the easyconfig itself.

@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Jun 11, 2024

@PetrKralCZ sorry for the confusion, i meant in the description of this PR, not the easyconfig itself.

It is needed for other easyconfig for a static library. When the flag is not used, the following error can occur:

libiml.a(libiml_la-basisop.o): relocation ​​​​​​​​​​​​​​​​R_X86_64_32 against `.rodata.str1.1'
can not be used when making a shared object; recompile with -fPIC

smoors
smoors approved these changes Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added the bug fix label Jun 11, 2024
@smoors smoors added this to the release after 4.9.2 milestone Jun 11, 2024
@smoors smoors enabled auto-merge June 11, 2024 08:40
@smoors smoors merged commit a7a900f into easybuilders:develop Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@PetrKralCZ @boegelbot @smoors