Skip to content

Add internal CUDA header patch for PSM2 v12.0.1#20804

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
bartoldeman:20240612140032_new_pr_PSM21201
Jun 13, 2024
Merged

Add internal CUDA header patch for PSM2 v12.0.1#20804
jfgrimm merged 1 commit intoeasybuilders:developfrom
bartoldeman:20240612140032_new_pr_PSM21201

Conversation

@bartoldeman
Copy link
Copy Markdown
Contributor

@bartoldeman bartoldeman commented Jun 12, 2024

(created using eb --new-pr)

@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Jun 12, 2024

This eliminates the CUDA builddependency by adding a minimal internal cuda.h header, exactly like we already did for Open MPI.

See #20794 and easybuilders/easybuild-framework#4560 for more info.

@bartoldeman bartoldeman requested a review from jfgrimm June 12, 2024 14:04
@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Jun 12, 2024

@boegelbot please test @ jsc-zen3

@bartoldeman
Copy link
Copy Markdown
Contributor Author

bartoldeman commented Jun 12, 2024

@boegelbot please test @ generoso

@bartoldeman bartoldeman added this to the release after 4.9.2 milestone Jun 12, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 12, 2024

@bartoldeman: Request for testing this PR well received on login1

PR test command 'EB_PR=20804 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20804 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13721

Test results coming soon (I hope)...

Details

- notification for comment with ID 2163114855 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 12, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/37e444a075c8e8ae93db7ac3a0e4b05e for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 12, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 13 out of 13 (7 easyconfigs in total)
node026.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/945a6b8d5f4f7d0c95c07533f91317fc for a full test report.

jfgrimm
jfgrimm approved these changes Jun 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch :)

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jun 13, 2024

Going in, thanks @bartoldeman!

@jfgrimm jfgrimm merged commit e1852d0 into easybuilders:develop Jun 13, 2024
@boegel boegel changed the title Add internal CUDA header patch for PSM2 Add internal CUDA header patch for PSM2 v12.0.1 Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoldeman @boegelbot @jfgrimm