Skip to content

add patch for JupyterHub support to recent tensorboard easyconfigs#20823

Merged
Micket merged 2 commits intoeasybuilders:developfrom
lexming:tensorboard-jupyter
Jun 14, 2024
Merged

add patch for JupyterHub support to recent tensorboard easyconfigs#20823
Micket merged 2 commits intoeasybuilders:developfrom
lexming:tensorboard-jupyter

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Jun 14, 2024

Changelog:

  • fix issue Support display tensorboard in JupyterHub tensorflow/tensorboard#3142 in tensorboard-2.10.0-foss-2022a.eb and tensorboard-2.15.1-gfbf-2023a.eb
  • tensorboard-2.15.1-gfbf-2023a.eb: replace extension on grpcio with regular dependency
  • tensorboard-2.15.1-gfbf-2023a.eb: remove deprecated tensorboard_plugin_wit and add tensorboard-plugin-profile to be on par with TensorFlow v2.15.1

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jun 14, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 14, 2024

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=20823 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20823 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13745

Test results coming soon (I hope)...

Details

- notification for comment with ID 2168064046 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/89a653150418a9dbeab559dc993a2b0a for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Jun 14, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 14, 2024

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20823 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20823 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4389

Test results coming soon (I hope)...

Details

- notification for comment with ID 2168093626 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/aac297bbd911004cb5322f6b192fa76d for a full test report.

Micket
Micket approved these changes Jun 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the release after 4.9.2 milestone Jun 14, 2024
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 14, 2024

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/29ee860170fd69c41cc15363feb11066 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Jun 14, 2024

Going in, thanks @lexming!

@Micket Micket merged commit 0d5c94f into easybuilders:develop Jun 14, 2024
@lexming lexming deleted the tensorboard-jupyter branch June 16, 2024 22:40
@lexming lexming mentioned this pull request Sep 11, 2024
Merged
@boegel boegel changed the title add support for JupyterHub to TensorBoard add patch for JupyterHub support to recent tensorboard easyconfigs Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @boegelbot @Micket