Skip to content

Remove maturin build dependency from langchain-antropic#20825

Merged
smoors merged 1 commit intoeasybuilders:developfrom
WilleBell:patch-1
Jun 15, 2024
Merged

Remove maturin build dependency from langchain-antropic#20825
smoors merged 1 commit intoeasybuilders:developfrom
WilleBell:patch-1

Conversation

@WilleBell
Copy link
Copy Markdown
Contributor

@WilleBell WilleBell commented Jun 14, 2024

No description provided.

@smoors smoors changed the title Remove maturin, it is not needed as builddependency Remove maturin build dependency from langchain-antropic Jun 14, 2024
@smoors smoors added the bug fix label Jun 14, 2024
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 14, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 14, 2024

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=20825 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20825 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13747

Test results coming soon (I hope)...

Details

- notification for comment with ID 2168332222 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/1589a078d13b740f76c97acbf7152de8 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 15, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 15, 2024

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20825 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20825 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4397

Test results coming soon (I hope)...

Details

- notification for comment with ID 2169182937 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 15, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/90bf198d7e9898a09d1b704de9659540 for a full test report.

@smoors smoors added this to the release after 4.9.2 milestone Jun 15, 2024
smoors
smoors approved these changes Jun 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jun 15, 2024

Going in, thanks @WilleBell!

@smoors smoors merged commit c158afa into easybuilders:develop Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@WilleBell @smoors @boegelbot