Skip to content

use proper dependencies for Safetensors and tokenizers in Transformers v4.30.2#20869

Merged
lexming merged 2 commits intoeasybuilders:5.0.xfrom
Micket:20240620120208_new_pr_Safetensors043
Dec 19, 2024
Merged

use proper dependencies for Safetensors and tokenizers in Transformers v4.30.2#20869
lexming merged 2 commits intoeasybuilders:5.0.xfrom
Micket:20240620120208_new_pr_Safetensors043

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Jun 20, 2024 •
edited
Loading

(created using eb --new-pr)

see #20718

@Micket Micket added the update label Jun 20, 2024
@Micket Micket added this to the 5.0 milestone Jun 20, 2024
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Jun 20, 2024

@boegelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Jun 20, 2024

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/f8eeb627cd59c6785a11280ad1913907 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 20, 2024

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20869 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20869 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13791

Test results coming soon (I hope)...

Details

- notification for comment with ID 2181402290 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 20, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/39dd859d9914117b76c2b10ba1e405cf for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Jun 20, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 20, 2024

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20869 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20869 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4437

Test results coming soon (I hope)...

Details

- notification for comment with ID 2181422896 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jun 20, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/515cfe36ef2205a19061c05cc4a1c0c1 for a full test report.

@Micket Micket changed the base branch from develop to 5.0.x December 15, 2024 22:56
@Micket Micket force-pushed the 20240620120208_new_pr_Safetensors043 branch from f4b8d7a to 9591733 Compare December 15, 2024 23:49
@Micket Micket added the EasyBuild-5.0 EasyBuild 5.0 label Dec 16, 2024
lexming
lexming approved these changes Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 19, 2024

Merging, thanks @Micket !

@lexming lexming merged commit d282e39 into easybuilders:5.0.x Dec 19, 2024
@Micket Micket deleted the 20240620120208_new_pr_Safetensors043 branch December 19, 2024 18:45
@boegel boegel changed the title Use external deps for safetensors and tokenizers in Transformers-4.30.2 use proper dependencies for Safetensors and tokenizers in Transformers v4.30.2 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

EasyBuild-5.0 EasyBuild 5.0 update

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @boegelbot @lexming