Skip to content

Remove CMake Arrow flag as there is no Arrow dependency in recent GDAL easyconfigs#20905

Merged
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20240625163035_new_pr_GDAL362
Jun 27, 2024
Merged

Remove CMake Arrow flag as there is no Arrow dependency in recent GDAL easyconfigs#20905
boegel merged 1 commit intoeasybuilders:developfrom
branfosj:20240625163035_new_pr_GDAL362

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jun 25, 2024

(created using eb --new-pr)

I tried adding Arrow as a dependency in #20901, but that went badly. So I am instead proposing the code cleanup option.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 25, 2024

What's the implication of not (correctly) specifying -DArrow_DIR? Does GDAL then use an internal Arrow, or does it not support certain features?

@branfosj
Copy link
Copy Markdown
Member Author

What's the implication of not (correctly) specifying -DArrow_DIR? Does GDAL then use an internal Arrow, or does it not support certain features?

I'm seeing the same output from CMake with and without this:

-- Could NOT find Arrow (missing: Arrow_DIR)
-- The following features have been disabled:
[snip]
 * ogr_ARROW, Arrow
-- The following OPTIONAL packages have not been found:
[ship]
 * Arrow
   Apache Arrow C++ library

So I am saying there is no internal Arrow fallback and our GDAL does not contain support for Arrow - either before or after this PR.

@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/70f01e64738d397a511eb05836965655 for a full test report.

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Remove CMake Arrow flag as there is no Arrow dependency in recent GDAL Remove CMake Arrow flag as there is no Arrow dependency in recent GDAL easyconfigs Jun 27, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 27, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20905 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20905 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13827

Test results coming soon (I hope)...

Details

- notification for comment with ID 2194152936 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 27, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20905 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20905 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4472

Test results coming soon (I hope)...

Details

- notification for comment with ID 2194176228 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/c9186a5a192ec1fd10a94baedcc1dde2 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/9c12c9741285205a42b08fc70b89956b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 27, 2024

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3121.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/27d62dd023824e76fe14678adebe572c for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 27, 2024

Going in, thanks @branfosj!

@boegel boegel merged commit 7808d42 into easybuilders:develop Jun 27, 2024
@branfosj branfosj deleted the 20240625163035_new_pr_GDAL362 branch June 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants