Skip to content

{lib}[GCCcore/12.3.0] Highway 1.0.4 fix for failing test on zen4#20942

Merged
boegel merged 2 commits intoeasybuilders:developfrom
trz42:20240629112950_new_pr_Highway104
Jul 31, 2024
Merged

{lib}[GCCcore/12.3.0] Highway 1.0.4 fix for failing test on zen4#20942
boegel merged 2 commits intoeasybuilders:developfrom
trz42:20240629112950_new_pr_Highway104

Conversation

@trz42
Copy link
Copy Markdown

@trz42 trz42 commented Jun 29, 2024

(created using eb --new-pr)

@trz42 trz42 mentioned this pull request Jun 29, 2024
Merged
@trz42 trz42 changed the title fixes bug that resulted in test failure on zen4 {lib}[GCCcore/12.3.0] Highway 1.0.4 fix for failing test on zen4 Jun 29, 2024
@trz42 trz42 mentioned this pull request Jun 29, 2024
Merged
boegel
boegel requested changes Jul 3, 2024
View reviewed changes
Comment thread easybuild/easyconfigs/h/Highway/Highway-1.0.4-zen4-fix-TruncateTo-bug.patch
@@ -0,0 +1,44 @@
diff --git a/hwy/ops/x86_256-inl.h b/hwy/ops/x86_256-inl.h
Copy link
Copy Markdown
Member

@boegel boegel Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trz42 Can you add a description on top of the patch to explain why this is required (fix failing test on AMD Genoa a.k.a. Zen4 systems), including a pointer to google/highway#1913, and maybe also a bit of info on how you trimmed it down to just this minimal patch + add yourself as patch author.

Keep in mind that this implies updating the SHA256 checksum for the patch file in the easyconfig

Copy link
Copy Markdown
Contributor

@akesandgren akesandgren Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trz42 Ping, please update the patch file with the requested info.
I need this asap :-)

Copy link
Copy Markdown
Author

@trz42 trz42 Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel @akesandgren Added a description of the patch file. Let me know if you need additional information.

Note, I haven't tested the updated PR/easyconfig yet.

Copy link
Copy Markdown
Author

@trz42 trz42 Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still builds for Zen4 on top of EESSI. See EESSI/software-layer#627 (comment)

Copy link
Copy Markdown
Author

@trz42 trz42 Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked the EasyBuild logs for the build. All looking good.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 3, 2024

@boegelbot please test @ generoso
EB_ARGS="--installpath /tmp/20942"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 3, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20942 EB_ARGS="--installpath /tmp/20942" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20942 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13872

Test results coming soon (I hope)...

Details

- notification for comment with ID 2205482063 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 3, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2362fd177a85bc2cc8acaaffba4788df for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 4, 2024 •
edited
Loading

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 4, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20942 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20942 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4526

Test results coming soon (I hope)...

Details

- notification for comment with ID 2209468528 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 4, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/c568df9ce23f5c97b6be9034aaafa305 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 5, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3158.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/15df7a3cab79630629858bc5575eac63 for a full test report.

@boegel boegel added the bug fix label Jul 5, 2024
@boegel boegel added this to the release after 4.9.2 milestone Jul 5, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 5, 2024 •
edited
Loading

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4214.shinx.os - Linux RHEL 9.2, x86_64, AMD EPYC 9654 96-Core Processor, Python 3.9.16
See https://gist.github.com/boegel/eba615933d6dc0ec7916488ad306b710 for a full test report.

edit: this was on a AMD Genoa (zen4) system

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 31, 2024

@boegelbot please test @ generoso
EB_ARGS="--installpath /tmp/20942"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 31, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20942 EB_ARGS="--installpath /tmp/20942" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20942 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13984

Test results coming soon (I hope)...

Details

- notification for comment with ID 2260707506 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jul 31, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4ca3904224b3ff792cdc94e9f2df59d9 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 31, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4201.shinx.os - Linux RHEL 9.4, x86_64, AMD EPYC 9654 96-Core Processor (zen4), Python 3.9.18
See https://gist.github.com/boegel/0d17e7d76279134d8c46c04dc5cb365b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jul 31, 2024

Going in, thanks @trz42!

@boegel boegel merged commit 524da37 into easybuilders:develop Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren left review comments

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

5 participants

@trz42 @boegel @boegelbot @akesandgren @truib