List M4 as a dependency for GMP 6#2096
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
ok to test |
|
@riccardomurri I prefer if you add the |
|
+1 on Autotools |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4898/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
I find the Autotools dependency overkill, but here you are :-) |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4914/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4915/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
use '' as version, otherwise the M4 dependency is not loaded
There was a problem hiding this comment.
Done, for this and the other ones. Should I change the dummy toolchain version in the M4 build file as well?
What's the purpose of the "version" field in a dummy toolchain, anyway? and why does it matter?
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4919/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Test report by @boegel |
|
@riccardomurri: failed test report due to fluke on my end, ignore |
|
Test report by @boegel |
|
Test report by @nathanhaigh |
I think most of these failures are because of a lack of intel toolchains on my system |
|
lgtm |
|
Hmm, after extending this to also the GMP 6.1.0 easyconfigs we have now, I noticed that I'd like to avoid doing that, since when building stuff with the system compiler (as is implied by using So, I would include builddependencies = [
('Autotools', '20150215'),
]to make If sites want to make sure they only have one @riccardomurri: thoughts on this? I can build on top of your PR to make this happen, since a couple of extra |
|
Test report by @boegel |
|
I agree with @boegel 's last comment: build with parent toolchain and let sites decide if they want to use the "minimal toolchain" option to only ever build Autotools etc. once |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5787/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
don't hardcode toolchain for Autotools build dep
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5788/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
add missing easyconfigs
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5789/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
fix version conflict on M4
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5796/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Going in, thanks @riccardomurri! |
List M4 as a dependency for GMP 6
See issue #2095 for details.
M4 is added as a dependency built with the "dummy" toolchain, as there is no need to optimize it.
(In principle, adding it as an OS/package dependency would work equally well.)