Skip to content

List M4 as a dependency for GMP 6#2096

Merged
boegel merged 12 commits intoeasybuilders:developfrom
riccardomurri:2095_m4_dependency_for_gmp6
Jan 23, 2016
Merged

List M4 as a dependency for GMP 6#2096
boegel merged 12 commits intoeasybuilders:developfrom
riccardomurri:2095_m4_dependency_for_gmp6

Conversation

@riccardomurri
Copy link
Copy Markdown
Contributor

See issue #2095 for details.

M4 is added as a dependency built with the "dummy" toolchain, as there is no need to optimize it.
(In principle, adding it as an OS/package dependency would work equally well.)

@hpcugentbot
Copy link
Copy Markdown

Automatic reply from Jenkins: Can I test this?

@wpoely86
Copy link
Copy Markdown
Member

ok to test

@wpoely86
Copy link
Copy Markdown
Member

@riccardomurri I prefer if you add the autotools bundle as a build dep. It includes the everything the build process might need.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 29, 2015

+1 on Autotools

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4898/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@riccardomurri
Copy link
Copy Markdown
Contributor Author

I find the Autotools dependency overkill, but here you are :-)

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4914/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4915/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel added this to the v2.4.0 milestone Oct 29, 2015
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use '' as version, otherwise the M4 dependency is not loaded

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, for this and the other ones. Should I change the dummy toolchain version in the M4 build file as well?

What's the purpose of the "version" field in a dummy toolchain, anyway? and why does it matter?

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4919/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 29, 2015

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (2 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ad9df4adc61133f0d8f0 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 29, 2015

Test report by @boegel
FAILED
Build succeeded for 10 out of 11 (11 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/9b5f49a5547427ccfc44 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 29, 2015

@riccardomurri: failed test report due to fluke on my end, ignore

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 29, 2015

Test report by @boegel
FAILED
Build succeeded for 10 out of 11 (11 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/c6e703ea2ae9af1603db for a full test report.

@boegel boegel modified the milestones: v2.4.0, v2.5.0 Nov 9, 2015
@boegel boegel modified the milestones: v2.5.0, v2.6.0 Dec 14, 2015
@boegel boegel removed this from the v2.5.0 milestone Dec 14, 2015
@nathanhaigh
Copy link
Copy Markdown
Contributor

Test report by @nathanhaigh
FAILED
Build succeeded for 13 out of 24 (11 easyconfigs in this PR)
Linux ubuntu 14.04, Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz, Python 2.7.6
See https://gist.github.com/5aac44be2e00d3754c1c for a full test report.

@nathanhaigh
Copy link
Copy Markdown
Contributor

  • GCC-4.7.2.eb
    /usr/bin/ld: cannot find crti.o: No such file or directory
  • GMP-6.0.0a-GCC-4.7.2.eb
    No module found for toolchain: GCC/4.7.2
  • Others

I think most of these failures are because of a lack of intel toolchains on my system

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 17, 2016

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 17, 2016

Hmm, after extending this to also the GMP 6.1.0 easyconfigs we have now, I noticed that Autotools is being included explicitly as built with a dummy toolchain.

I'd like to avoid doing that, since when building stuff with the system compiler (as is implied by using dummy) you're at the mercy of what the OS provides, and we lose 'control'.

So, I would include Autotools as:

builddependencies = [
    ('Autotools', '20150215'),
]

to make Autotools be built with the 'parent' toolchain.

If sites want to make sure they only have one Autotools build for every version (which is a site-specific decision imho), the correct way would be to use the (currently still experimental) 'minimal toolchains' setting, cfr. http://easybuild.readthedocs.org/en/latest/Manipulating_dependencies.html#minimal-toolchains . Having resolving dependencies with minimal toolchains enabled by default may become the default setting in EasyBuild v3.0 (but I'm getting way ahead of myself now).

@riccardomurri: thoughts on this? I can build on top of your PR to make this happen, since a couple of extra Autotools easyconfigs will have to be added for now, let me know.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 17, 2016

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/ec048cf4a52be0bf652c for a full test report.

@riccardomurri
Copy link
Copy Markdown
Contributor Author

I agree with @boegel 's last comment: build with parent toolchain and let sites decide if they want to use the "minimal toolchain" option to only ever build Autotools etc. once

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5787/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

don't hardcode toolchain for Autotools build dep
@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5788/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5789/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 23, 2016

Test report by @boegel
FAILED
Build succeeded for 40 out of 42 (42 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/c311e66348c1e968baca for a full test report.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5796/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 23, 2016

Test report by @boegel
SUCCESS
Build succeeded for 42 out of 42 (42 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/552471a5f9f5a2038f57 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 23, 2016

Going in, thanks @riccardomurri!

boegel added a commit that referenced this pull request Jan 23, 2016
@boegel boegel merged commit fccbfeb into easybuilders:develop Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants