Skip to content

remove duplicate (explicit) versionsuffix from UCC-CUDA#20966

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:remove-cuda-suffix
Oct 14, 2025
Merged

remove duplicate (explicit) versionsuffix from UCC-CUDA#20966
boegel merged 3 commits intoeasybuilders:developfrom
Flamefire:remove-cuda-suffix

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Jul 4, 2024

It is cleaner with less room for mistakes to use the existing variable instead of redefining the same string multiple times.

I suggest to do the same for all other ECs using a (CUDA) versionsuffix and dependencies using the same.

Flamefire added 2 commits July 4, 2024 14:59
@Flamefire
remove duplicate (explicit) versionsuffix from UCC-CUDA
a1697a1 
It is cleaner with less room for mistakes to use the existing variable
instead of redefining the same string multiple times.
@Flamefire
Merge branch 'develop' into remove-cuda-suffix
c8877cc
@Thyre
Copy link
Copy Markdown
Collaborator

Thyre commented Oct 10, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath=/tmp/$USER/ecpr-20966"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 10, 2025

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20966 EB_ARGS="--installpath=/tmp/$USER/ecpr-20966" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20966 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 8270

Test results coming soon (I hope)...

Details

- notification for comment with ID 3389797143 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 10, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c3.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/965622fc9e5fce0ebe0d7b5acb564f71 for a full test report.

boegel
boegel approved these changes Oct 14, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the next release (5.2.0?) milestone Oct 14, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 14, 2025

Going in, thanks @Flamefire!

@boegel boegel merged commit 1e841c3 into easybuilders:develop Oct 14, 2025
8 checks passed
@Flamefire Flamefire deleted the remove-cuda-suffix branch October 14, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

2022a 2022b 2023a code cleanup ready-to-review

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @Thyre @boegelbot @boegel