Is this only for v1.8.2?
The git v1.7.12 easyconfigs have

configopts = "--enable-pthreads='-lpthread'"

instead. This doesn't work with git v1.8.2?

It does. The workaround you mention is used only in git-1.7.12-ictce-4.0.6.eb, and I was using git-1.7.12-goolf-1.4.10.eb as a base.

So, why is it not there in the other easyconfigs? Is it because we don't notice the issue on our end?

What issue does this resolve, exactly?

I don't know why it is not needed in other easyconfigs. The issue is described in the comment. configure knows about LIBS and will think that it does not need to do anything extra to get pthread linked in. But configure will not pass LIBS to Makefile, and linking will fail.

@gribozavr: Did you actually run into the issue yourself? Do you still have the exact error message that occurs? That (and Google) might help us (and others) in the future.

It's probably need it for the others as well, my guess is that this only fails on certain systems or with certain OS packages installed.

The commit (by myself) that introduced it is 2fec9f7, but that doesn't give much information as to why it's there exactly.

@gribozavr: Please add that line to the other git easyconfigs as well, to keep them consistent.

Then this is ready to merge in...

Yes, I did run into the issue. A developer on IRC confirmed that he sees an issue here.

I have sent an email to the mailing list, but did not get a reply yet:
http://marc.info/?l=git&m=136500220703901&w=2

Here's the error text for the record:

    AR libgit.a
    LINK git-credential-store
    LINK git-http-backend
    LINK git-fast-import
    LINK git-daemon
libgit.a(run-command.o): In function `run_thread':
run-command.c:(.text+0x11e): undefined reference to `pthread_setspecific'
libgit.a(run-command.o): In function `die_async':
run-command.c:(.text+0x166): undefined reference to `pthread_getspecific'
libgit.a(run-command.o): In function `start_async':
run-command.c:(.text+0x109f): undefined reference to `pthread_create'
run-command.c:(.text+0x1103): undefined reference to `pthread_key_create'
libgit.a(run-command.o): In function `finish_async':
run-command.c:(.text+0x1267): undefined reference to `pthread_join'
collect2: error: ld returned 1 exit status
make: *** [git-credential-store] Error 1
make: *** Waiting for unfinished jobs....

I added this change to other easyconfigs.

Hi there,

great thing to push again the git easyconfig, because some repairs were indeed pending over here (mea culpa):

• notably, the current build does not properly support all 3 transport mechanisms of git,
  we need to clarify its dependencies to get it done right (cURL and what else, need to investigate).

Looks like it is cURL and expat. Added them as dependencies.

@fgeorgatos: Is there an easy way to check whether a git build supports all 3 transport mechanism, i.e. something we can check via a sanity check command? Please follow-up on this in another pull request if so.

On Tue, Apr 9, 2013 at 9:59 PM, Kenneth Hoste [email protected]:

@fgeorgatos https://github.com/fgeorgatos: Is there an easy way to
check whether a git build supports all 3 transport mechanism, i.e.
something we can check via a sanity check command? Please follow-up on this
in another pull request if so.

Not that I know of, but I agree it's desirable if there is one...

ps. will check what is missing in this one as part of a quality control
before v1.3.1 release... do we have ETA?

Let's add dependencies here, too!

Also, I suggest you put your name in the header.
More generally, I like the idea of having 2 authors per easyconfig: it may help down the road, for communications redundancy...

@fgeorgatos I don't have Intel Compilers, so I'll leave adding additional dependencies to someone who can test the result. Git 1.8.2 easyconfig is tested.