Skip to content

{geo}[foss/2023a] SeisSol v1.1.4, ImpalaJIT v20211028, ASAGI v1.0, easi v1.3.0#21065

Merged
ocaisa merged 12 commits intoeasybuilders:developfrom
JinyuHan99:20240726011323_new_pr_SeisSol114
Jun 20, 2025
Merged

{geo}[foss/2023a] SeisSol v1.1.4, ImpalaJIT v20211028, ASAGI v1.0, easi v1.3.0#21065
ocaisa merged 12 commits intoeasybuilders:developfrom
JinyuHan99:20240726011323_new_pr_SeisSol114

Conversation

@JinyuHan99
Copy link
Copy Markdown

(created using eb --new-pr)

easybuild added 2 commits July 26, 2024 01:13
…JIT-29102021-foss-2023a.eb, ASAGI-1.0-foss-2023a.eb, easi-1.3.0-foss-2023a.eb, pkg-config-0.29.2-GCCcore-12.3.0.eb and patches: ASAGI-CMakeList.patch, ASAGI-level.h.patch
@sassy-crick
Copy link
Copy Markdown
Collaborator

@JinyuHan99 You might want to sync your PR with development, something like this:

eb --sync-pr-with-develop NUMBER_OF_PR

Also, we now have a fixed Python-3 version per toolchain, so usually we do not need the -Python suffix any more. Could you please check the correct Python version for the toolchain you are using and change the EasyConfig file accordingly?

@boegel boegel added this to the 5.x milestone Jun 20, 2025
Comment thread easybuild/easyconfigs/a/ASAGI/ASAGI-1.0-foss-2023a.eb Outdated
Comment thread easybuild/easyconfigs/a/ASAGI/ASAGI-1.0-foss-2023a.eb Outdated
Comment thread easybuild/easyconfigs/a/ASAGI/ASAGI-1.0-foss-2023a.eb Outdated
}]
patches = [
('ASAGI-CMakeList.patch', 0),
('ASAGI-level.h.patch', 0),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch files should be renamed to reflect the ASAGI version they're intended for, like ASAGI-1.0_CMakeList.patch

Comment thread easybuild/easyconfigs/a/ASAGI/ASAGI-1.0-foss-2023a.eb Outdated
Comment thread easybuild/easyconfigs/a/ASAGI/ASAGI-1.0-foss-2023a.eb Outdated
Comment thread easybuild/easyconfigs/a/ASAGI/ASAGI-1.0-foss-2023a.eb Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2025

Don't apply any of the changes please, I'll push a commit into the PR once I've done some testing on my end

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21065 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21065 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6930

Test results coming soon (I hope)...

Details

- notification for comment with ID 2990819618 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Comment thread easybuild/easyconfigs/a/ASAGI/ASAGI-1.0_fix-level.h.patch
boegel
boegel previously approved these changes Jun 20, 2025
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2025

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3515.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/de7d8599a34639489e480074f2e69f39 for a full test report.

@boegel boegel changed the title {geo}[foss/2023a] SeisSol v1.1.4, ImpalaJIT v29102021, ASAGI v1.0, ... w/ Python 3.11.3 {geo}[foss/2023a] SeisSol v1.1.4, ImpalaJIT v20211028, ASAGI v1.0, easi v1.3.0 Jun 20, 2025
@boegel boegel removed the change label Jun 20, 2025
@boegel boegel force-pushed the 20240726011323_new_pr_SeisSol114 branch from 102504c to fae52d3 Compare June 20, 2025 12:44
@easybuilders easybuilders deleted a comment from boegelbot Jun 20, 2025
@easybuilders easybuilders deleted a comment from boegelbot Jun 20, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21065 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21065 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6936

Test results coming soon (I hope)...

Details

- notification for comment with ID 2991454219 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 20, 2025

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3594.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/fe4dd33581c904565cbb9933ef20fe07 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/bd3817d98ff69b748e6d978d82183ccc for a full test report.

Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit c4c0451 into easybuilders:develop Jun 20, 2025
8 checks passed
@boegel boegel modified the milestones: 5.x, 5.1.1 Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants