New easyconfig for DFT-D3#2107
Conversation
|
Automatic reply from Jenkins: Can I test this? |
|
Yes. |
There was a problem hiding this comment.
for non-versioned tarballs, please include a checksum too
(or maybe even require to rename the tarball as well)
There was a problem hiding this comment.
A checksum has now been added. I don't know how we could require that the tarball (especially if it is downloaded from a remote server) be renamed.
There was a problem hiding this comment.
We don't have support to automagically rename the tarball yet on download, but we should look into that.
For now, this will do.
|
Jenkins: ok to test |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4932/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4943/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5211/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
I'm now getting a different checksum, so was a new version released?
I'd suggest to use dftd3-%(version)s.tgz as source file name, implying that it should be downloaded manually and renamed (until we have support for automagically renaming on download in the framework), since this is not going to work out well otherwise, clearly...
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5309/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5418/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel: I've added the version decoration in the name, added a comment and taken out checksum verification (the authors of the software unfortunately aren't above stealth upgrades). Let me know if you would like further changes. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5427/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5634/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Jenkins: test this please |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5644/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
There was a problem hiding this comment.
the comment above is actually a reason to keep the checksum in place...
how else can EB be sure that the source tarball you're using matches the version specified?
There was a problem hiding this comment.
w.r.t. the stealth upgrades: if it happens, we want to know about it, and the checksum should be updated then
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6322/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
| # reason, it is suggested to manually download and rename the tarball. The | ||
| # checksum may also need updating from time to time. | ||
| sources = ['dftd3-%(version)s.tgz'] | ||
| checksums = [('md5', '88470bd398b5cc90ad680ed1df4239f7')] |
There was a problem hiding this comment.
hmm, I'm getting 5d1cbaa851cd88ae515dea3cc9a7590d
and it still seems to be v3.1.1?
There was a problem hiding this comment.
@boegel: Yes, and it looks as though it was last updated on 11 January. Probably another stealth upgrade...sigh.
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6357/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6460/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/6543/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@valtandor: this can't be merged until the checksum is updated? |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7102/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@boegel I've just updated the checksum, but I don't know that it won't change again (though my OS reports that the tarball was last changed on 11 January, so hopefully it's sort of stable). |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/7560/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
lgtm |
|
Test report by @boegel |
|
Going in, thanks @valtandor! |
No description provided.