Skip to content

stop RStudio-Server 2023.09 from installing R packages (+ move to foss/2023a toolchain)#21175

Merged
boegel merged 2 commits intoeasybuilders:developfrom
branfosj:rstudio
Aug 14, 2024
Merged

stop RStudio-Server 2023.09 from installing R packages (+ move to foss/2023a toolchain)#21175
boegel merged 2 commits intoeasybuilders:developfrom
branfosj:rstudio

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Aug 13, 2024 •
edited
Loading

This looks to fix #21167 (comment)

We only look to have been having this problem with https://github.com/branfosj/easybuild-easyconfigs/blob/rstudio/easybuild/easyconfigs/r/RStudio-Server/RStudio-Server-2023.12.1%2B402-gfbf-2023b-Java-11-R-4.3.3.eb and https://github.com/branfosj/easybuild-easyconfigs/blob/rstudio/easybuild/easyconfigs/r/RStudio-Server/RStudio-Server-2023.09.1%2B494-foss-2023a-Java-11-R-4.3.2.eb, but not with the older versions of RStudio-Server. This PR fixes RStudio-Server-2023.09.1+494-foss-2023a-Java-11-R-4.3.2.eb. However, there is no (merged) R-bundle-CRAN (to provide renv) that we can use for RStudio-Server-2023.12.1+402-gfbf-2023b-Java-11-R-4.3.3.eb, so I've not fixed that one.

@branfosj branfosj added this to the release after 4.9.2 milestone Aug 13, 2024
@branfosj branfosj marked this pull request as draft August 13, 2024 16:40
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 13, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 13, 2024

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=21175 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21175 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14063

Test results coming soon (I hope)...

Details

- notification for comment with ID 2286677089 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Aug 13, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 13, 2024

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=21175 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21175 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14064

Test results coming soon (I hope)...

Details

- notification for comment with ID 2286731004 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 13, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/33fcbc25694e61a41ac9f227ab873ee8 for a full test report.

@branfosj branfosj marked this pull request as ready for review August 14, 2024 08:03
@boegel boegel changed the title stop RStudio-Server installing R packages stop RStudio-Server installing R packages (+ move to foss/2023b toolchain) Aug 14, 2024
@boegel boegel added the change label Aug 14, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 14, 2024

@boegelbot please test @ jsc-zen3

@boegel boegel changed the title stop RStudio-Server installing R packages (+ move to foss/2023b toolchain) stop RStudio-Server 2023.09 from installing R packages (+ move to foss/2023b toolchain) Aug 14, 2024
@boegel boegel changed the title stop RStudio-Server 2023.09 from installing R packages (+ move to foss/2023b toolchain) stop RStudio-Server 2023.09 from installing R packages (+ move to foss/2023a toolchain) Aug 14, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 14, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21175 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21175 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4677

Test results coming soon (I hope)...

Details

- notification for comment with ID 2288299400 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/ef7fc5f2404cce0b8ee213b499684293 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 14, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3103.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/7c956ddb31d4d861dadfe27a2d48f746 for a full test report.

boegel
boegel approved these changes Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit e35fdb5 into easybuilders:develop Aug 14, 2024
@branfosj branfosj deleted the rstudio branch August 14, 2024 12:16
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Aug 14, 2024

Test report by @verdurin
FAILED
Build succeeded for 0 out of 2 (1 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/c9cf272e7b78680c1417dd060b32d4ed for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Aug 15, 2024

Test report by @verdurin
FAILED
Build succeeded for 3 out of 5 (1 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/1654be4ca393d8baa9a6b719578f1324 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

4 participants

@branfosj @boegelbot @boegel @verdurin