Skip to content

fix build of STAR 2.7.11a + 2.7.11b on non-x86 architectures by avoiding use of -maxv2 + add missing xxd build dependency#21200

Merged
boegel merged 4 commits intoeasybuilders:developfrom
jpecar:20240816223943_new_pr_STAR2711b
Aug 20, 2024
Merged

fix build of STAR 2.7.11a + 2.7.11b on non-x86 architectures by avoiding use of -maxv2 + add missing xxd build dependency#21200
boegel merged 4 commits intoeasybuilders:developfrom
jpecar:20240816223943_new_pr_STAR2711b

Conversation

@jpecar
Copy link
Copy Markdown
Contributor

@jpecar jpecar commented Aug 16, 2024

(created using eb --new-pr)

boegel
boegel requested changes Aug 16, 2024
View reviewed changes
Comment thread easybuild/easyconfigs/s/STAR/STAR-2.7.11b-GCC-13.2.0.eb Outdated
boegel
boegel requested changes Aug 16, 2024
View reviewed changes
Comment thread easybuild/easyconfigs/s/STAR/STAR-2.7.11b-GCC-13.2.0.eb Outdated
{'STAR-2.7.11a_use-external-htslib.patch': '2fdc3ed9372d983f77d861d6f16a60a553598358dce9ff8216f96eb20e63ce4e'},
]

#by default this is set to -mavx2 which makes it fail on non x86 systems
Copy link
Copy Markdown
Member

@boegel boegel Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code style check fails because there's a space missing after #

Copy link
Copy Markdown
Contributor Author

@jpecar jpecar Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least that's easy to fix ;)

@boegel boegel added the bug fix label Aug 16, 2024
@boegel boegel added this to the release after 4.9.2 milestone Aug 16, 2024
@trz42 trz42 mentioned this pull request Aug 19, 2024
Merged
@boegel boegel changed the title update STAR to make it build on non-x86_64 architectures fix build of STAR 2.7.11a + 2.7.11b on non-x86 architectures, by avoiding use of -maxv2 Aug 20, 2024
boegel
boegel previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 20, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 20, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21200 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21200 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14086

Test results coming soon (I hope)...

Details

- notification for comment with ID 2298202041 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 20, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/7ff9809ec6484690c958bbcd63743cee for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 20, 2024

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
aarch64-neoverse-n1-node1.int.aws-rocky88-202310.eessi.io - Linux Rocky Linux 8.8, AArch64, ARM UNKNOWN (neoverse_n1), Python 3.6.8
See https://gist.github.com/boegel/fbe24ce7c2bcaa8df6d4ee9b50290c03 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 20, 2024

@boegelbot please test @ jsc-zen3

@boegel boegel added aarch64 Related to Arm 64-bit (aarch64) EESSI Related to EESSI project labels Aug 20, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 20, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21200 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21200 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4697

Test results coming soon (I hope)...

Details

- notification for comment with ID 2298407483 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 20, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/529e29c820fa2c7e0d95339500182d0e for a full test report.

@boegel boegel changed the title fix build of STAR 2.7.11a + 2.7.11b on non-x86 architectures, by avoiding use of -maxv2 fix build of STAR 2.7.11a + 2.7.11b on non-x86 architectures by avoiding use of -maxv2 + add missing xxd build dependency Aug 20, 2024
boegel
boegel approved these changes Aug 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 20, 2024

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3116.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/b12477c01b00231d1ee85419c5a14fa0 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 20, 2024

Going in, thanks @jpecar!

@boegel boegel merged commit 147eb36 into easybuilders:develop Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

aarch64 Related to Arm 64-bit (aarch64) bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@jpecar @boegel @boegelbot