Skip to content

add patch for HDF5 v1.14.3 to suppress fp exceptions#21280

Merged
smoors merged 1 commit intoeasybuilders:developfrom
Louwrensth:HDF5-1.14.3-hotfix
Aug 30, 2024
Merged

add patch for HDF5 v1.14.3 to suppress fp exceptions#21280
smoors merged 1 commit intoeasybuilders:developfrom
Louwrensth:HDF5-1.14.3-hotfix

Conversation

@Louwrensth
Copy link
Copy Markdown
Collaborator

@Louwrensth Louwrensth commented Aug 28, 2024

HDF5 v1.14.3 was broken, this patch is the hotfix that was published soon after the release.

See: HDFGroup/hdf5#3831

@Louwrensth
adding patch: HDF5-1.14.3_suppress_fp_exceptions.patch
d5acbaf 
HDF5 v1.14.3 was broken, this patch is the hotfix that
was published soon after the release. See:

HDFGroup/hdf5#3831
@Louwrensth Louwrensth mentioned this pull request Aug 28, 2024
Closed
@smoors smoors added the bug fix label Aug 30, 2024
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 30, 2024

@boegelbot please test @ jsc-zen3

@smoors smoors added this to the release after 4.9.2 milestone Aug 30, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2024

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21280 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21280 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4779

Test results coming soon (I hope)...

Details

- notification for comment with ID 2322074079 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/90704b2657b9121a3d3909683389d302 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 30, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2024

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=21280 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21280 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14170

Test results coming soon (I hope)...

Details

- notification for comment with ID 2322150256 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Aug 30, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c54a66ec1f4666e1e0f7c5346ac843d2 for a full test report.

smoors
smoors approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Aug 30, 2024

Going in, thanks @Louwrensth!

@smoors smoors merged commit 36ea487 into easybuilders:develop Aug 30, 2024
@SimonPinches SimonPinches mentioned this pull request Aug 31, 2024
Closed
@boegel boegel changed the title adding patch: HDF5-1.14.3_suppress_fp_exceptions.patch add patch for HDF5-1.14.3 to suppress fp exceptions Sep 11, 2024
@boegel boegel changed the title add patch for HDF5-1.14.3 to suppress fp exceptions add patch for HDF5 v1.14.3 to suppress fp exceptions Sep 11, 2024
@Louwrensth Louwrensth deleted the HDF5-1.14.3-hotfix branch September 27, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@Louwrensth @smoors @boegelbot