{devel} [intel-2015b] Qt 5.5.1 (REVIEW)#2136
Conversation
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4990/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4995/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
@wpoely86: please review? |
|
@hajgato: going with |
|
I would split it. New major version of Qt don't come that often and as they all can be loaded together, this is the proper way. |
There was a problem hiding this comment.
@boegel how far do you want to take the versionsuffix spread?
There was a problem hiding this comment.
I'm not sure. My gut feeling says it's ok here to not let it trickle up (since this is an uncommon dependency).
|
Test report by @wpoely86 |
missing dep for |
|
@hajgato: that's a good reason to go with |
|
Easyconfigs unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5039/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@wpoely86 For me it worked. |
|
@hajgato well, if you have yacc installed on your system, it will work 😉 |
|
@wpoely86 Well, that was also fixed. (this is what I referred in my previous comment) |
|
@hajgato okay, I will rerun the tests on my end. |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5042/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @wpoely86 |
|
@wpoely86 Mesa FTP? |
|
@hajgato FTP is blocked here. I will download it manually. |
|
Test report by @wpoely86 |
|
Test report by @wpoely86 |
|
@wpoely86 FTP again |
|
Test report by @wpoely86 |
|
@hajgato can you increase the |
|
@wpoely86 |
|
Test report by @wpoely86 |
|
Hurray! Good to go! |
There was a problem hiding this comment.
@hajgato: ok, please change?
It would be nice to get this PR in, it's rather big, and we know what happens with big easyconfig PRs that stay around for too long...
|
@hajgato: just a couple of tiny remarks, let's get this beast ready to merge! |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5177/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Test report by @boegel |
|
Going in, thanks @hajgato! |
{devel} [intel-2015b] Qt 5.5.1 (REVIEW)
Needs ~easybuilders/easybuild-easyblocks#740~~
(Sorry for this, it became a monster)