Skip to content

{devel} [intel-2015b] Qt 5.5.1 (REVIEW)#2136

Merged
boegel merged 6 commits intoeasybuilders:developfrom
hajgato:Qt5
Dec 9, 2015
Merged

{devel} [intel-2015b] Qt 5.5.1 (REVIEW)#2136
boegel merged 6 commits intoeasybuilders:developfrom
hajgato:Qt5

Conversation

@hajgato
Copy link
Copy Markdown
Collaborator

@hajgato hajgato commented Nov 12, 2015

Needs ~easybuilders/easybuild-easyblocks#740~~
(Sorry for this, it became a monster)

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4990/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hajgato hajgato changed the title {devel} [intel-2015b] Qt 5.5.1 (REVIEW) {devel} [intel-2015b] Qt 5.5.1 (WIP) Nov 12, 2015
@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/4995/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hajgato hajgato changed the title {devel} [intel-2015b] Qt 5.5.1 (WIP) {devel} [intel-2015b] Qt 5.5.1 (REVIEW) Nov 13, 2015
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 14, 2015

@wpoely86: please review? eb --review-pr is your friend here...

@boegel boegel added this to the v2.5.0 milestone Nov 14, 2015
@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2015

@boegel @wpoely86
Qt 4 and Qt 5 should be able to be loaded at the same time.
OpenFOAM 3.0.0 uses CAGL 4.7 (needs Qt5) and ParaView 4.4.0 (needs Qt4)
The only possibility what I see to rename Qt 5.5.1 to Qt5 5.5.1
Any other idea or suggestions?

@hajgato hajgato changed the title {devel} [intel-2015b] Qt 5.5.1 (REVIEW) {devel} [intel-2015b] Qt 5.5.1 (WIP) Nov 16, 2015
@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 16, 2015

@hajgato: going with Qt5 is the only way to combine Qt 4.x and 5.x... Unless you create a Qt4 of the last Qt 4.x version, and use that to combine it with Qt 5.x. Then we'll only have a single Qt4 4.x easyconfig around, and we can stay away from fragmenting into Qt, Qt5, Qt6, etc.

@wpoely86
Copy link
Copy Markdown
Member

I would split it. New major version of Qt don't come that often and as they all can be loaded together, this is the proper way.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel how far do you want to take the versionsuffix spread?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. My gut feeling says it's ok here to not let it trickle up (since this is an uncommon dependency).

@wpoely86
Copy link
Copy Markdown
Member

Test report by @wpoely86
FAILED
Build succeeded for 29 out of 33 (15 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c78c68a0df24e0d4abbc for a full test report.

@wpoely86
Copy link
Copy Markdown
Member

@hajgato

./build-aux/ylwrap: line 176: yacc: command not found

missing dep for libxkbcommon-0.5.0-intel-2015b.eb ?

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 16, 2015

@boegel @wpoely86 I am in favour to split to Qt5. Anyway, Qt 3 libs are libQt3*, Qt 4 libs are libQt[a-zA-Z]*, and Qt 5 libs are libQt5* (dont ask me why...

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 16, 2015

@hajgato: that's a good reason to go with Qt5 for Qt 5.x, and stick to Qt for Qt 4.x... Go for it.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite FAILed.

See https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5039/console for more details.

Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do.

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 17, 2015

@wpoely86 For me it worked.

@hajgato hajgato changed the title {devel} [intel-2015b] Qt 5.5.1 (WIP) {devel} [intel-2015b] Qt 5.5.1 (REVIEW) Nov 17, 2015
@wpoely86
Copy link
Copy Markdown
Member

@hajgato well, if you have yacc installed on your system, it will work 😉

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 17, 2015

@wpoely86 Well, that was also fixed. (this is what I referred in my previous comment)

@wpoely86
Copy link
Copy Markdown
Member

@hajgato okay, I will rerun the tests on my end.

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5042/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Copy Markdown
Member

Test report by @wpoely86
FAILED
Build succeeded for 30 out of 33 (15 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/18be4e85ed798c282375 for a full test report.

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 18, 2015

@wpoely86 Mesa FTP?

@wpoely86
Copy link
Copy Markdown
Member

@hajgato FTP is blocked here. I will download it manually.

@wpoely86
Copy link
Copy Markdown
Member

Test report by @wpoely86
FAILED
Build succeeded for 31 out of 33 (15 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/869994ff3b7875b482f9 for a full test report.

@wpoely86
Copy link
Copy Markdown
Member

Test report by @wpoely86
FAILED
Build succeeded for 31 out of 33 (15 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/09725fbaa00ed05dd46b for a full test report.

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 19, 2015

@wpoely86 FTP again

@wpoely86
Copy link
Copy Markdown
Member

Test report by @wpoely86
FAILED
Build succeeded for 32 out of 33 (15 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/ab72d1a5da976682b0e8 for a full test report.

@wpoely86
Copy link
Copy Markdown
Member

@hajgato can you increase the maxhits?

@hajgato
Copy link
Copy Markdown
Collaborator Author

hajgato commented Nov 19, 2015

@wpoely86 maxhits=120 added in the easyblock easybuilders/easybuild-easyblocks#740

@wpoely86
Copy link
Copy Markdown
Member

Test report by @wpoely86
SUCCESS
Build succeeded for 33 out of 33 (15 easyconfigs in this PR)
Linux centos linux 7.1.1503, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/d10482be0650084174c8 for a full test report.

@wpoely86
Copy link
Copy Markdown
Member

Hurray! Good to go!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be intltool?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel: probably

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hajgato: ok, please change?

It would be nice to get this PR in, it's rather big, and we know what happens with big easyconfig PRs that stay around for too long...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Its fixed.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 26, 2015

@hajgato: just a couple of tiny remarks, let's get this beast ready to merge!

@hpcugentbot
Copy link
Copy Markdown

Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5177/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 9, 2015

Test report by @boegel
SUCCESS
Build succeeded for 21 out of 21 (21 easyconfigs in this PR)
Linux SL 6.7, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.6.6
See https://gist.github.com/9003791a2b11334c243d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 9, 2015

Going in, thanks @hajgato!

boegel added a commit that referenced this pull request Dec 9, 2015
{devel} [intel-2015b] Qt 5.5.1 (REVIEW)
@boegel boegel merged commit 121f984 into easybuilders:develop Dec 9, 2015
@hajgato hajgato deleted the Qt5 branch June 8, 2017 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants