Skip to content

remove Highway build dependency in Brunsli easyconfigs, since it's not actually required at all#21366

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:20240910195618_new_pr_Brunsli01
Sep 10, 2024
Merged

remove Highway build dependency in Brunsli easyconfigs, since it's not actually required at all#21366
ocaisa merged 1 commit intoeasybuilders:developfrom
boegel:20240910195618_new_pr_Brunsli01

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 10, 2024

(created using eb --new-pr)

@boegel boegel added the bug fix label Sep 10, 2024
@boegel boegel added this to the release after 4.9.2 milestone Sep 10, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 10, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 10, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21366 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21366 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14235

Test results coming soon (I hope)...

Details

- notification for comment with ID 2341617662 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Sep 10, 2024 •
edited
Loading

Test report by @bedroge
SUCCESS
Build succeeded for 6 out of 6 (5 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 24.04.1 LTS (Noble Numbat), x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.12.3
See https://gist.github.com/bedroge/95da45b012c87d82a8bd44ac0f478477 for a full test report.

Skipped the ones for GCCcore 10.x, as I don't have those versions.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 10, 2024

@boegelbot please test @ jsc-zen3

@boegel boegel mentioned this pull request Sep 10, 2024
Closed
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 10, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns3 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6df5ec567750d06c888f64583e92a9dc for a full test report.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Sep 10, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 10, 2024

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21366 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21366 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4838

Test results coming soon (I hope)...

Details

- notification for comment with ID 2341654947 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 10, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/f5179a0879d7c140862f314af9190169 for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Sep 10, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 7 out of 7 (6 easyconfigs in total)
interactive1 - Linux Rocky Linux 8.9, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.6.8
See https://gist.github.com/bedroge/7867bd4b815caae5b6337e3c4d962f47 for a full test report.

ocaisa
ocaisa approved these changes Sep 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no mention of Highway in the Brunsli git repo

@ocaisa ocaisa enabled auto-merge September 10, 2024 18:14
@ocaisa ocaisa merged commit 79f5663 into easybuilders:develop Sep 10, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 10, 2024

LGTM, no mention of Highway in the Brunsli git repo

Yeah, I couldn't find anything either, also not in EasyBuild log for Brunsli installations (even though I also looked for -lhwy, hwy, etc.)

@boegel boegel deleted the 20240910195618_new_pr_Brunsli01 branch September 10, 2024 18:20
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 10, 2024

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3116.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/f573e171bf5e4c679a62d6e961e9d80c for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @boegelbot @bedroge @ocaisa