Skip to content

Fix repeated sanity check runs in manta#21435

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20240918125620_new_pr_manta111
Sep 21, 2024
Merged

Fix repeated sanity check runs in manta#21435
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20240918125620_new_pr_manta111

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Sep 18, 2024 •
edited
Loading

(created using eb --new-pr)

The sanity check test creates a folder which
a) makes the check fail when run again (e.g. --sanity-check-only)
b) leaves that folder inside the install dir

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 18, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
n1454 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/5ebb5a2ba243d57e9387146668355c27 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Sep 18, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 13 out of 13 (3 easyconfigs in total)
i7030 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/1556513ea5a9464ae736e3b00cd5aaad for a full test report.

boegel
boegel approved these changes Sep 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added the bug fix label Sep 21, 2024
@boegel boegel added this to the 4.9.4 milestone Sep 21, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 21, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 21, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21435 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21435 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14322

Test results coming soon (I hope)...

Details

- notification for comment with ID 2365198523 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 21, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 21, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21435 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21435 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4926

Test results coming soon (I hope)...

Details

- notification for comment with ID 2365200569 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 21, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns3 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a513feb67d07b609f7f0e345723a418a for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 21, 2024 •
edited by boegel
Loading

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 53 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/2382d688ff233fecb1ef1560428f03fa for a full test report.

edit (by @boegel): ignoring this, these toolchains are too old for Rocky Linux 9.x

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 21, 2024

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3107.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/3c88c6e384692d0a94857548ff0115c1 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Sep 21, 2024

Going in, thanks @Flamefire!

@boegel boegel merged commit b252e83 into easybuilders:develop Sep 21, 2024
@Flamefire Flamefire deleted the 20240918125620_new_pr_manta111 branch September 21, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.4

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @boegel @boegelbot