Skip to content

use -lncurses rather than -ltermcap for Term::ReadLine::GNU Perl extension#21469

Merged
lexming merged 1 commit intoeasybuilders:developfrom
boegel:20240923151401_new_pr_Perl5340
Sep 25, 2024
Merged

use -lncurses rather than -ltermcap for Term::ReadLine::GNU Perl extension#21469
lexming merged 1 commit intoeasybuilders:developfrom
boegel:20240923151401_new_pr_Perl5340

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Sep 23, 2024

(created using eb --new-pr)
fixes #17373

@boegel boegel added the bug fix label Sep 23, 2024
@boegel boegel added this to the release after 4.9.4 milestone Sep 23, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Sep 23, 2024

@boegelbot please test @ generoso
EB_ARGS="--installpath /tmp/$USER/pr21469"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 23, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21469 EB_ARGS="--installpath /tmp/$USER/pr21469" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21469 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14328

Test results coming soon (I hope)...

Details

- notification for comment with ID 2368241384 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Sep 23, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f0e0ff0ae118a65a7b1ef8af249cbb3b for a full test report.

@boegel boegel changed the title use -lncurses rather than -ltermcap for Term::ReadLine::GNU Perl extension use -lncurses rather than -ltermcap for Term::ReadLine::GNU Perl extension Sep 24, 2024
lexming
lexming approved these changes Sep 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Copy Markdown
Contributor

lexming commented Sep 25, 2024

Merging, thanks @boegel !

@lexming lexming merged commit 5865ca8 into easybuilders:develop Sep 25, 2024
@boegel boegel deleted the 20240923151401_new_pr_Perl5340 branch September 25, 2024 14:48
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Sep 25, 2024

Test report by @verdurin
SUCCESS
Build succeeded for 19 out of 19 (7 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/bab1026d98a179d66bff015ddca51eed for a full test report.

@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lexming lexming lexming approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Building Perl on SLES15 fails because -ltermcap is not found

4 participants

@boegel @boegelbot @lexming @verdurin