Skip to content

strip out '-minsize 1' option from umi_binning.sh in longread_umi 0.3.2, since it's not supported by VSEARCH#21557

Merged
laraPPr merged 1 commit intoeasybuilders:developfrom
boegel:20241005092756_new_pr_longread_umi032
Oct 7, 2024
Merged

strip out '-minsize 1' option from umi_binning.sh in longread_umi 0.3.2, since it's not supported by VSEARCH#21557
laraPPr merged 1 commit intoeasybuilders:developfrom
boegel:20241005092756_new_pr_longread_umi032

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Oct 5, 2024

(created using eb --new-pr)

@boegel boegel added the bug fix label Oct 5, 2024
@boegel boegel added this to the release after 4.9.4 milestone Oct 5, 2024
@boegel boegel requested a review from laraPPr October 5, 2024 08:17
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 5, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 5, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21557 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21557 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14404

Test results coming soon (I hope)...

Details

- notification for comment with ID 2394977175 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 5, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4012.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 545.23.08, Python 3.6.8
See https://gist.github.com/boegel/914aa82e9eaf4927d88514e4063c9258 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 5, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/572e61b0846161a7b18e2a6dd0457812 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Oct 5, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 5, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21557 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21557 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5005

Test results coming soon (I hope)...

Details

- notification for comment with ID 2394978574 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 5, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/1a375c912af907ce6b60e26e28d04dcb for a full test report.

laraPPr
laraPPr approved these changes Oct 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Oct 7, 2024

Going in, thanks @boegel!

@laraPPr laraPPr merged commit eb6f280 into easybuilders:develop Oct 7, 2024
@boegel boegel changed the title strip out '-minsize 1' option from umi_binning.sh in longread_umi 0.3.2, since it's not supported by VSEARCH strip out '-minsize 1' option from umi_binning.sh in longread_umi 0.3.2, since it's not supported by VSEARCH Oct 9, 2024
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laraPPr laraPPr laraPPr approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @laraPPr