fix installation of NextPolish v1.4.1 when RPATH linking is used (+ move to `GCC` toolchain) by pavelToman · Pull Request #21588 · easybuilders/easybuild-easyconfigs

pavelToman · 2024-10-08T13:35:22Z

(created using eb --new-pr)
resolves vscentrum/vsc-software-stack#398
requires:

add patch to fix alignment bug in patchelf 0.18.0 #21674

fix for easyconfig contributed via #21265

pavelToman · 2024-10-08T14:47:14Z

@boegelbot please test @ generoso

boegelbot · 2024-10-08T14:50:09Z

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=21588 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21588 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 14425

Test results coming soon (I hope)...

Details

- notification for comment with ID 2400064332 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-10-08T14:54:37Z

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/56bb1a5b0b0ed6393ae4585f65addae4 for a full test report.

pavelToman · 2024-10-08T15:01:07Z

@boegelbot please test @ jsc-zen3

pavelToman · 2024-10-08T15:02:20Z

@laraPPr could you please test it on shinx for the RPATH?

boegelbot · 2024-10-08T15:10:11Z

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21588 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21588 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 5029

Test results coming soon (I hope)...

Details

- notification for comment with ID 2400099567 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-10-08T15:13:04Z

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/8a61ca222d2801d5a0758f6f5c91c247 for a full test report.

boegel · 2024-10-08T17:43:49Z

@boegelbot please test @ jsc-zen3
EB_BRANCH=5.0.x

boegel

@pavelToman We should remove the NextPolish-1.4.1-GCCcore-12.3.0.eb that was added in #21265, since that can't work when RPATH linking is enabled?

boegelbot · 2024-10-08T17:50:18Z

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=21588 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_21588 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 5030

Test results coming soon (I hope)...

Details

- notification for comment with ID 2400465788 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel

@pavelToman NextPolish-1.4.1-GCCcore-12.3.0.eb should be removed in this PR too?

pavelToman · 2024-10-16T12:57:31Z

@boegelbot please test @ generoso

boegelbot · 2024-10-16T13:00:09Z

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=21588 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21588 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 14488

Test results coming soon (I hope)...

Details

- notification for comment with ID 2416770123 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-10-16T13:03:40Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2c0bc851cef179a604f252ea9d872eda for a full test report.

pavelToman · 2024-10-16T13:08:27Z

@boegelbot please test @ jsc-zen3

boegelbot · 2024-10-16T13:10:09Z

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21588 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21588 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 5090

Test results coming soon (I hope)...

Details

- notification for comment with ID 2416794720 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-10-16T13:13:06Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/1f43a119747ce839a67dd2cb4ded8035 for a full test report.

boegel · 2024-10-16T13:21:13Z

@boegelbot please test @ jsc-zen3
EB_ARGS="--rpath --installpath /tmp/$USER/pr21588"

boegel

lgtm

boegelbot · 2024-10-16T13:30:11Z

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21588 EB_ARGS="--rpath --installpath /tmp/$USER/pr21588" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21588 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 5092

Test results coming soon (I hope)...

Details

- notification for comment with ID 2416825698 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-10-16T13:33:01Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/56b48ea68afd8daecc9a18148c8b7149 for a full test report.

boegel · 2024-10-16T13:37:03Z

Going in, thanks @pavelToman!

update RPATH in NextPolish + patch patchelf-0.18.0

5637fe5

pavelToman mentioned this pull request Oct 8, 2024

NextPolish vscentrum/vsc-software-stack#398

Closed

3 tasks

jfgrimm reviewed Oct 8, 2024

View reviewed changes

Comment thread easybuild/easyconfigs/n/NextPolish/NextPolish-1.4.1-GCC-12.3.0.eb Outdated

boegel requested changes Oct 8, 2024

View reviewed changes

boegel mentioned this pull request Oct 8, 2024

add support for %(rpath_enabled)s template value easybuilders/easybuild-framework#4670

Merged

pavelToman mentioned this pull request Oct 9, 2024

{bio}[GCCcore/12.3.0] NextPolish v1.4.1 #21265

Merged

boegel requested changes Oct 15, 2024

View reviewed changes

Comment thread easybuild/easyconfigs/n/NextPolish/NextPolish-1.4.1-GCC-12.3.0.eb Outdated

boegel added the bug fix label Oct 16, 2024

boegel added this to the release after 4.9.4 milestone Oct 16, 2024

pavelToman mentioned this pull request Oct 16, 2024

add patch to fix alignment bug in patchelf 0.18.0 #21674

Merged

boegel mentioned this pull request Oct 16, 2024

fix failing RPATH sanity check for recent dorado easyconfigs using foss/2023a toolchain #21673

Merged

pavelToman added 2 commits October 16, 2024 11:09

Revert changes to patchelf - separated PR created

5710105

Separated PR created for patchelf fix - easybuilders#21674

f112ff2

pavelToman changed the title ~~update RPATH in NextPolish + patch patchelf-0.18.0~~ {bio}[GCC/12.3.0] NextPolish v1.4.1 Oct 16, 2024

Merge branch 'develop' into 20241008153518_new_pr_NextPolish141

b6da1f6

boegel requested changes Oct 16, 2024

View reviewed changes

Comment thread easybuild/easyconfigs/n/NextPolish/NextPolish-1.4.1-GCC-12.3.0.eb Outdated

pavelToman added 2 commits October 16, 2024 13:35

remove GCCcore version from PR 21265

b1df92f

update postinstallcmds to fix RPATH

bd543be

boegel changed the title ~~{bio}[GCC/12.3.0] NextPolish v1.4.1~~ fix installation of NextPolish v1.4.1 when RPATH linking is used Oct 16, 2024

boegel changed the title ~~fix installation of NextPolish v1.4.1 when RPATH linking is used~~ fix installation of NextPolish v1.4.1 when RPATH linking is used (+ move to GCC toolchain) Oct 16, 2024

boegel added the change label Oct 16, 2024

boegel approved these changes Oct 16, 2024

View reviewed changes

boegel merged commit f3db6b7 into easybuilders:develop Oct 16, 2024

boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025

Conversation

pavelToman commented Oct 8, 2024 • edited by boegel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pavelToman commented Oct 8, 2024

Uh oh!

boegelbot commented Oct 8, 2024

Uh oh!

boegelbot commented Oct 8, 2024

Uh oh!

pavelToman commented Oct 8, 2024

Uh oh!

pavelToman commented Oct 8, 2024

Uh oh!

boegelbot commented Oct 8, 2024

Uh oh!

boegelbot commented Oct 8, 2024

Uh oh!

Uh oh!

boegel commented Oct 8, 2024

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

boegelbot commented Oct 8, 2024

Uh oh!

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pavelToman commented Oct 16, 2024

Uh oh!

boegelbot commented Oct 16, 2024

Uh oh!

boegelbot commented Oct 16, 2024

Uh oh!

pavelToman commented Oct 16, 2024

Uh oh!

boegelbot commented Oct 16, 2024

Uh oh!

boegelbot commented Oct 16, 2024

Uh oh!

boegel commented Oct 16, 2024

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

boegelbot commented Oct 16, 2024

Uh oh!

boegelbot commented Oct 16, 2024

Uh oh!

boegel commented Oct 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pavelToman commented Oct 8, 2024 •

edited by boegel

Loading