Skip to content

stop using --buildtype=release in easyconfigs using MesonNinja easyblock#21619

Merged
boegel merged 3 commits intoeasybuilders:5.0.xfrom
Micket:meson
Oct 15, 2024
Merged

stop using --buildtype=release in easyconfigs using MesonNinja easyblock#21619
boegel merged 3 commits intoeasybuilders:5.0.xfrom
Micket:meson

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Oct 10, 2024

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 10, 2024

Test report by @Micket
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3454
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/18087124489f6e00fd77d58b05983c3b for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 11, 2024

perhaps worth adding a CI check that catches new easyconfigs that use --buildtype release etc?

jfgrimm
jfgrimm previously approved these changes Oct 14, 2024
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Fix flags for updated mesonninja easyblock Fix flags for updated MesonNinja easyblock Oct 14, 2024
@boegel boegel changed the title Fix flags for updated MesonNinja easyblock stop using --buildtype=release in easyconfigs using MesonNinja easyblock Oct 14, 2024
Comment thread test/easyconfigs/easyconfigs.py Outdated
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 15, 2024

Test report by @boegel
SUCCESS
Build succeeded for 58 out of 58 (58 easyconfigs in total)
node3508.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/boegel/dd87c0fa03817aa050c790792b06f310 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 15, 2024

Going in, thanks @Micket!

@boegel boegel merged commit 392db74 into easybuilders:5.0.x Oct 15, 2024
@Micket Micket deleted the meson branch October 15, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants