Skip to content

{phys}[GCCcore/13.2.0] Lime 1.3.2#21630

Merged
jfgrimm merged 13 commits intoeasybuilders:developfrom
jkuhl-uni:LIME-1.3.2
Oct 15, 2024
Merged

{phys}[GCCcore/13.2.0] Lime 1.3.2#21630
jfgrimm merged 13 commits intoeasybuilders:developfrom
jkuhl-uni:LIME-1.3.2

Conversation

@jkuhl-uni
Copy link
Copy Markdown
Contributor

@jkuhl-uni jkuhl-uni commented Oct 14, 2024

Hey,
this time, I am, in fact, contributing something for my own research community :D
This is a very simple library. For the LIME packaging scheme.

jfgrimm
jfgrimm requested changes Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpicks

Comment thread easybuild/easyconfigs/l/LIME/LIME-1.3.2-GCCcore-12.3.0.eb Outdated
Comment thread easybuild/easyconfigs/l/LIME/LIME-1.3.2-GCCcore-12.3.0.eb Outdated
Comment thread easybuild/easyconfigs/l/LIME/LIME-1.3.2-GCCcore-12.3.0.eb Outdated
Comment thread easybuild/easyconfigs/l/LIME/LIME-1.3.2-GCCcore-12.3.0.eb
jkuhl-uni and others added 2 commits October 15, 2024 15:39
@jkuhl-uni @jfgrimm
no explicit prefix
cf5dda8 
Co-authored-by: Jasper Grimm <[email protected]>
@jkuhl-uni @jfgrimm
no explicit dir check
8b1cac1 
Co-authored-by: Jasper Grimm <[email protected]>
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 15, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 15, 2024

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=21630 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21630 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14477

Test results coming soon (I hope)...

Details

- notification for comment with ID 2413966666 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 15, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6765b490382adb82c5ca9851f3cbd428 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 15, 2024

@boegelbot: please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 15, 2024

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21630 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21630 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5077

Test results coming soon (I hope)...

Details

- notification for comment with ID 2414183746 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Oct 15, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/f64d16691be3d708041944e34a820245 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 15, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
login2.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/363b4c181823a86fe26af4879dea7bd7 for a full test report.

@jfgrimm jfgrimm added this to the release after 4.9.4 milestone Oct 15, 2024
jfgrimm
jfgrimm approved these changes Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm added the new label Oct 15, 2024
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Oct 15, 2024

Going in, thanks @jkuhl-uni!

@jfgrimm jfgrimm merged commit e118118 into easybuilders:develop Oct 15, 2024
@jkuhl-uni jkuhl-uni deleted the LIME-1.3.2 branch October 15, 2024 15:36
@jkuhl-uni jkuhl-uni mentioned this pull request Oct 17, 2024
Merged
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jkuhl-uni @jfgrimm @boegelbot @boegel