Skip to content

add RISC-V support to R-bundle-CRAN easyconfigs by adding/improving patches for liquidSVM and ff extensions#21726

Merged
bedroge merged 27 commits intoeasybuilders:developfrom
julianmorillo:easybuild-easyconfigs-R-bundle-CRAN
Jul 18, 2025
Merged

add RISC-V support to R-bundle-CRAN easyconfigs by adding/improving patches for liquidSVM and ff extensions#21726
bedroge merged 27 commits intoeasybuilders:developfrom
julianmorillo:easybuild-easyconfigs-R-bundle-CRAN

Conversation

@julianmorillo
Copy link
Copy Markdown
Contributor

No description provided.

@julianmorillo julianmorillo changed the title Add RISC-V support to liquidSVM extension build for R-bundle-CRAN-2024.06-foss-2023b.eb Add RISC-V support to R-bundle-CRAN-2024.06-foss-2023b.eb Oct 23, 2024
@boegel boegel added riscv EESSI Related to EESSI project labels Nov 6, 2024
@boegel boegel added this to the 4.x milestone Nov 6, 2024
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Jul 11, 2025

Not sure what's going on here, it's complaining about a file that's not touched by this PR (anymore):

AssertionError: Verification for R-bundle-CRAN-2023.12-foss-2023a.eb failed:
Invalid checksum for patch file liquidSVM-1.2.4-fix_ppc_and_aarch64_build.patch of extension kableExtra: {'liquidSVM-1.2.4-fix_ppc_and_aarch64_build.patch': '46b09e441c3b59af535f20d8db0dee7f1d6a7ddd511175d252115b53cb8b86f8'}

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Jul 11, 2025

Ah, you removed the patch first, and then restored it with an additional newline, which changed the checksum.

But in order to not having to duplicate the patch, let's apply the same patch to 2023a version anyway. I'll run a test for that one on only x86_64, just to make sure that it doesn't break anything (it shouldn't, as the additional RISC-V change is very minimal).

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Jul 11, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr21726"

@boegelbot
Copy link
Copy Markdown
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21726 EB_ARGS="--installpath /tmp/$USER/pr21726" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21726 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7235

Test results coming soon (I hope)...

Details

- notification for comment with ID 3063211016 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/6fa5e92213a92cda8dcca732cd9af799 for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Jul 14, 2025

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
starfive - Linux Debian GNU/Linux 2.15, RISCV64, UNKNOWN, Python 3.10.9
See https://gist.github.com/bedroge/c1cefdae14126248e4125b7a797a071e for a full test report.

Comment thread easybuild/easyconfigs/r/R-bundle-CRAN/R-bundle-CRAN-2024.06-foss-2023b.eb Outdated
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Jul 14, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--installpath /tmp/$USER/pr21726"

@julianmorillo julianmorillo force-pushed the easybuild-easyconfigs-R-bundle-CRAN branch from f0456cb to 07c7df9 Compare July 15, 2025 15:32
@boegelbot
Copy link
Copy Markdown
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21726 EB_ARGS="--installpath /tmp/$USER/pr21726" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21726 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7249

Test results coming soon (I hope)...

Details

- notification for comment with ID 3070378594 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/0bc0d71977e59621255cd7e138663293 for a full test report.

@bedroge bedroge changed the title Add RISC-V support to R-bundle-CRAN-2024.06-foss-2023b.eb add RISC-V support to R-bundle-CRAN easyconfigs Jul 18, 2025
Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge bedroge modified the milestones: 5.x, release after 5.1.1 Jul 18, 2025
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Jul 18, 2025

Going in, thanks @julianmorillo!

@bedroge bedroge merged commit a87b51f into easybuilders:develop Jul 18, 2025
16 checks passed
@julianmorillo julianmorillo deleted the easybuild-easyconfigs-R-bundle-CRAN branch July 18, 2025 08:30
@boegel boegel changed the title add RISC-V support to R-bundle-CRAN easyconfigs add RISC-V support to R-bundle-CRAN easyconfigs by adding/improving patches for liquidSVM and ff extensions Jul 31, 2025
@boegel boegel added enhancement and removed change labels Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EESSI Related to EESSI project enhancement riscv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants