Skip to content

fix bug in HTSplotter-2.11 through runtime patching via sed#21812

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
PetrKralCZ:20241108140057_new_pr_HTSplotter211
Nov 24, 2024
Merged

fix bug in HTSplotter-2.11 through runtime patching via sed#21812
branfosj merged 1 commit intoeasybuilders:developfrom
PetrKralCZ:20241108140057_new_pr_HTSplotter211

Conversation

@PetrKralCZ
Copy link
Copy Markdown
Collaborator

@PetrKralCZ PetrKralCZ commented Nov 8, 2024 •
edited
Loading

(created using eb --new-pr)
resolves vscentrum/vsc-software-stack#433

@github-actions github-actions Bot added the change label Nov 8, 2024
@PetrKralCZ PetrKralCZ mentioned this pull request Nov 8, 2024
Closed
2 tasks
@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Nov 8, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 8, 2024

@PetrKralCZ: Request for testing this PR well received on login1

PR test command 'EB_PR=21812 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21812 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14667

Test results coming soon (I hope)...

Details

- notification for comment with ID 2464785418 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 8, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/dd83c8bddaa97772818176280eca0115 for a full test report.

@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Nov 8, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 8, 2024

@PetrKralCZ: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21812 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21812 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5234

Test results coming soon (I hope)...

Details

- notification for comment with ID 2464803589 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 8, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/fcedccaa4c919795b9706e3164c927c3 for a full test report.

@branfosj branfosj added this to the release after 4.9.4 milestone Nov 24, 2024
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Nov 24, 2024

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
bear-pg0210u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8480CL (sapphirerapids), Python 3.6.8
See https://gist.github.com/branfosj/ad37b0c4f71438d77c479e02ea63e3b1 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Nov 24, 2024

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/0008d400171661cd2b8d93f3b2fb8d6c for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Nov 24, 2024

Going in, thanks @PetrKralCZ!

@branfosj branfosj merged commit 2ffb95a into easybuilders:develop Nov 24, 2024
@boegel boegel changed the title bugfix of HTSplotter-2.11 fix bug in HTSplotter-2.11 through runtime patching via sed Dec 4, 2024
@boegel boegel added bug fix and removed change labels Dec 4, 2024
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

HTSplotter

4 participants

@PetrKralCZ @boegelbot @branfosj @boegel