Skip to content

add missing hatchling build dependency for scArches 0.6.1 w/ foss/2023a#21844

Merged
smoors merged 1 commit intoeasybuilders:developfrom
boegel:20241113105810_new_pr_scArches061
Nov 17, 2024
Merged

add missing hatchling build dependency for scArches 0.6.1 w/ foss/2023a#21844
smoors merged 1 commit intoeasybuilders:developfrom
boegel:20241113105810_new_pr_scArches061

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 13, 2024

(created using eb --new-pr)
similar to #21809, caused by changing hatchling to build dep for scanpy in #21657

@boegel boegel added bug fix and removed change labels Nov 13, 2024
@boegel boegel added this to the release after 4.9.4 milestone Nov 13, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 13, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 13, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21844 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21844 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5258

Test results coming soon (I hope)...

Details

- notification for comment with ID 2473068048 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 13, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/691cd26b9ab6336987e0874102de288f for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 13, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 13, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21844 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21844 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14701

Test results coming soon (I hope)...

Details

- notification for comment with ID 2473227489 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 13, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/cede4eaf4adc9bd29835add1918a4de0 for a full test report.

smoors
smoors approved these changes Nov 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 17, 2024

Going in, thanks @boegel!

@smoors smoors merged commit bd23505 into easybuilders:develop Nov 17, 2024
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @smoors