Skip to content

{tools}[foss/2023b] kaggle v1.6.17#21854

Merged
laraPPr merged 1 commit intoeasybuilders:developfrom
PetrKralCZ:20241114162324_new_pr_kaggle1617
Dec 20, 2024
Merged

{tools}[foss/2023b] kaggle v1.6.17#21854
laraPPr merged 1 commit intoeasybuilders:developfrom
PetrKralCZ:20241114162324_new_pr_kaggle1617

Conversation

@PetrKralCZ
Copy link
Copy Markdown
Collaborator

@PetrKralCZ PetrKralCZ commented Nov 14, 2024 •
edited
Loading

(created using eb --new-pr)
resolves vscentrum/vsc-software-stack#423

@PetrKralCZ PetrKralCZ added the new label Nov 14, 2024
@PetrKralCZ PetrKralCZ mentioned this pull request Nov 14, 2024
Closed
10 tasks
@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Nov 14, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 14, 2024

@PetrKralCZ: Request for testing this PR well received on login1

PR test command 'EB_PR=21854 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21854 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14713

Test results coming soon (I hope)...

Details

- notification for comment with ID 2476797770 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/de397656aa251007334647d1a5ed170d for a full test report.

@PetrKralCZ
Copy link
Copy Markdown
Collaborator Author

PetrKralCZ commented Nov 14, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 14, 2024

@PetrKralCZ: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21854 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21854 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5279

Test results coming soon (I hope)...

Details

- notification for comment with ID 2476818054 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/ca6c4667c6bdf4f07d241b0b1c7ddb3a for a full test report.

boegel
boegel previously requested changes Nov 16, 2024
View reviewed changes
Comment thread easybuild/easyconfigs/k/kaggle/kaggle-1.6.17-foss-2023b.eb
Comment on lines +41 to +43
# `import kaggle` fails for missing API token (`kaggle.json`)
# see `api.authenticate()` in `kaggle/__init__.py`
'modulename': False,
Copy link
Copy Markdown
Member

@boegel boegel Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, just try importing kaggle.api instead?

Suggested change
# `import kaggle` fails for missing API token (`kaggle.json`)
# see `api.authenticate()` in `kaggle/__init__.py`
'modulename': False,
'modulename': 'kaggle.api',

Copy link
Copy Markdown
Collaborator Author

@PetrKralCZ PetrKralCZ Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't help because either way the kaggle/__init__.py gets executed.

== 2024-11-18 09:28:29,815 build_log.py:171 ERROR EasyBuild crashed with an error (at easybuild/easybuild-framework/easybuild/base/exceptions.py:126 in __init__): Sanity check failed: extensions sanity check failed for 1 extensions: kaggle
failing sanity check for 'kaggle' extension: command "python -c "import kaggle.api"" failed; output:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/scratch/gent/vo/001/gvo00117/easybuild/RHEL8/cascadelake-ampere-ib/software/kaggle/1.6.17-foss-2023b/lib/python3.11/site-packages/kaggle/__init__.py", line 7, in <module>
    api.authenticate()
  File "/scratch/gent/vo/001/gvo00117/easybuild/RHEL8/cascadelake-ampere-ib/software/kaggle/1.6.17-foss-2023b/lib/python3.11/site-packages/kaggle/api/kaggle_api_extended.py", line 407, in authenticate
    raise IOError('Could not find {}. Make sure it\'s located in'
OSError: Could not find kaggle.json. Make sure it's located in /user/gent/453/vsc45304/.config/kaggle. Or use the environment method. See setup instructions at https://github.com/Kaggle/kaggle-api/,  (at easybuild/easybuild-framework/easybuild/framework/easyblock.py:3670 in _sanity_check_step)

Copy link
Copy Markdown
Member

@boegel boegel Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, then let's just go with False, and keep the comment

@boegel boegel added this to the 4.x milestone Nov 16, 2024
@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Dec 20, 2024

Test report by @laraPPr
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3127.skitty.os - Linux RHEL 9.4, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.11.3
See https://gist.github.com/laraPPr/5f19025dd96d979ea311fea57b60641d for a full test report.

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Dec 20, 2024

Test report by @laraPPr
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3536.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.11.3
See https://gist.github.com/laraPPr/a119dd4bcf2d6ec63dc0e595f2263195 for a full test report.

laraPPr
laraPPr approved these changes Dec 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr laraPPr dismissed boegel’s stale review December 20, 2024 14:20

requested changes addressed

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Dec 20, 2024

Going in, thanks @PetrKralCZ!

@laraPPr laraPPr merged commit ef644ae into easybuilders:develop Dec 20, 2024
@laraPPr laraPPr modified the milestones: 4.x, release after 4.9.4 Dec 20, 2024
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel left review comments

@laraPPr laraPPr laraPPr approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

kaggle

4 participants

@PetrKralCZ @boegelbot @laraPPr @boegel