Skip to content

use original sources for enchant-2 v2.6.5#21944

Merged
smoors merged 1 commit intoeasybuilders:developfrom
WilleBell:20241129183549_new_pr_enchant-2265
Dec 2, 2024
Merged

use original sources for enchant-2 v2.6.5#21944
smoors merged 1 commit intoeasybuilders:developfrom
WilleBell:20241129183549_new_pr_enchant-2265

Conversation

@WilleBell
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 2, 2024

@WilleBell i can still download the sources at https://github.com/AbiWord/enchant/archive/refs/tags/v2.6.5.tar.gz

what's the difference between the original and the fork?

@WilleBell
Copy link
Copy Markdown
Contributor Author

@WilleBell i can still download the sources at https://github.com/AbiWord/enchant/archive/refs/tags/v2.6.5.tar.gz

what's the difference between the original and the fork?

The checksum of that source is different (but very probably ok too, I didn't check). No difference between the original and the fork afaik. Doesn't it make sense to take the source at the original repo then?

@smoors smoors changed the title Source is no longer available in that fork use original sources for enchant-2 Dec 2, 2024
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 2, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=21944 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21944 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14796

Test results coming soon (I hope)...

Details

- notification for comment with ID 2512093868 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c2466baf65c819baddcc5d4b0f3537cc for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 2, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21944 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21944 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5365

Test results coming soon (I hope)...

Details

- notification for comment with ID 2512142090 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/26ae833c04c9c4c5413e0397de368d5d for a full test report.

@smoors smoors added this to the release after 4.9.4 milestone Dec 2, 2024
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 2, 2024

Going in, thanks @WilleBell!

@smoors smoors merged commit 1b92c00 into easybuilders:develop Dec 2, 2024
@boegel boegel added bug fix and removed change labels Dec 4, 2024
@boegel boegel changed the title use original sources for enchant-2 use original sources for enchant-2 v2.6.5 Mar 18, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants