Skip to content

{perf}[gfbf/2023a] HolisticTraceAnalysis v0.2.0#21987

Merged
akesandgren merged 3 commits intoeasybuilders:developfrom
VRehnberg:20241206152007_new_pr_HolisticTraceAnalysis020
Feb 5, 2025
Merged

{perf}[gfbf/2023a] HolisticTraceAnalysis v0.2.0#21987
akesandgren merged 3 commits intoeasybuilders:developfrom
VRehnberg:20241206152007_new_pr_HolisticTraceAnalysis020

Conversation

@VRehnberg
Copy link
Copy Markdown
Contributor

@VRehnberg VRehnberg commented Dec 6, 2024

(created using eb --new-pr)

@github-actions github-actions Bot added the new label Dec 6, 2024
@VRehnberg
Copy link
Copy Markdown
Contributor Author

VRehnberg commented Dec 6, 2024

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-icelake-build - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/VRehnberg/9163034617c0214797c2a09ffa39f614 for a full test report.

@VRehnberg
Copy link
Copy Markdown
Contributor Author

VRehnberg commented Dec 6, 2024

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis2-01 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6226R CPU @ 2.90GHz, 2 x NVIDIA Tesla T4, 560.35.03, Python 3.6.8
See https://gist.github.com/VRehnberg/3140ef8dab24245bb5cb178e76c1817c for a full test report.

@VRehnberg
Copy link
Copy Markdown
Contributor Author

VRehnberg commented Dec 6, 2024

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-icelake-build - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/VRehnberg/56fa19ed37325573c75e7da7463d08bd for a full test report.

lcniel
lcniel approved these changes Dec 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lcniel lcniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

akesandgren
akesandgren requested changes Feb 4, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/h/HolisticTraceAnalysis/HolisticTraceAnalysis-0.2.0-gfbf-2023a.eb Outdated
Comment thread easybuild/easyconfigs/h/HolisticTraceAnalysis/HolisticTraceAnalysis-0.2.0-gfbf-2023a.eb
Comment thread easybuild/easyconfigs/h/HolisticTraceAnalysis/HolisticTraceAnalysis-0.2.0-gfbf-2023a.eb
@VRehnberg VRehnberg requested a review from akesandgren February 4, 2025 15:28
@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Feb 4, 2025

@boegelbot Please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 4, 2025

@akesandgren: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21987 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21987 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5661

Test results coming soon (I hope)...

Details

- notification for comment with ID 2634428264 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 4, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/06956d29c1c205ddfaf68621c86bd719 for a full test report.

@akesandgren akesandgren added this to the release after 4.9.4 milestone Feb 5, 2025
akesandgren
akesandgren approved these changes Feb 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Feb 5, 2025

Going in, thanks @VRehnberg!

@akesandgren akesandgren merged commit f47e943 into easybuilders:develop Feb 5, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

+1 more reviewer

@lcniel lcniel lcniel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@VRehnberg @akesandgren @boegelbot @lcniel @boegel