Skip to content

add TorchRL to PyTorch-bundle v2.1.2#22000

Merged
smoors merged 1 commit intoeasybuilders:developfrom
lexming:20241210155207_new_pr_PyTorch-bundle212
Dec 18, 2024
Merged

add TorchRL to PyTorch-bundle v2.1.2#22000
smoors merged 1 commit intoeasybuilders:developfrom
lexming:20241210155207_new_pr_PyTorch-bundle212

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Dec 10, 2024

(created using eb --new-pr)

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Dec 10, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 10, 2024

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=22000 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22000 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14850

Test results coming soon (I hope)...

Details

- notification for comment with ID 2532054587 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Dec 11, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 11, 2024

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22000 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22000 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5428

Test results coming soon (I hope)...

Details

- notification for comment with ID 2535406912 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 11, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/ce71f5b9a49affd9544f48d48e3928a4 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Dec 13, 2024

@boegelbot please test @ generoso
EB_ARGS="PyTorch-bundle-2.1.2-foss-2023a.eb"
CORE_CNT=16

@easybuilders easybuilders deleted a comment from boegelbot Dec 13, 2024
@easybuilders easybuilders deleted a comment from boegelbot Dec 13, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 13, 2024

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=22000 EB_ARGS="PyTorch-bundle-2.1.2-foss-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22000 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14862

Test results coming soon (I hope)...

Details

- notification for comment with ID 2541145716 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 13, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/dd69f161ff0d87e197ad848e96c5c913 for a full test report.

smoors
smoors approved these changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the release after 4.9.4 milestone Dec 18, 2024
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 18, 2024

Going in, thanks @lexming!

@smoors smoors merged commit 486b723 into easybuilders:develop Dec 18, 2024
@lexming lexming deleted the 20241210155207_new_pr_PyTorch-bundle212 branch December 18, 2024 13:24
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lexming @boegelbot @smoors @boegel