Skip to content

Set $PKG_CONFIG in pkgconf modules#22005

Merged
smoors merged 1 commit intoeasybuilders:developfrom
Micket:20241210233647_new_pr_pkgconf180
Dec 12, 2024
Merged

Set $PKG_CONFIG in pkgconf modules#22005
smoors merged 1 commit intoeasybuilders:developfrom
Micket:20241210233647_new_pr_pkgconf180

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Dec 10, 2024 •
edited
Loading

(created using eb --new-pr)

I believe this would solve #21980

It also makes it needless to add the extra export to ImageMagick so i cleaned those up.

This prevents configure tools from trying to find their own pkg-config somewhere (even when we have it in PATH). I think it's a cross-compilation thing, where they look for x86_64-xxx-linux-gnu-pkg-config by default or something like that. This should tell those tools to no; use this exakt PKG_CONFIG please.

Untested.

@Micket Micket added the bug fix label Dec 10, 2024
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 12, 2024

@boegelbot: please test @ generoso
EB_ARGS="--installpath /tmp/$USER/pr22005"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2024

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=22005 EB_ARGS="--installpath /tmp/$USER/pr22005" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22005 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14857

Test results coming soon (I hope)...

Details

- notification for comment with ID 2538723522 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 18 out of 18 (18 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6d95a9ce81f1198279dc4f36e056e246 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 12, 2024

the installations /tmp all succeeded, let's install for real now

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 12, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2024

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=22005 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22005 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14859

Test results coming soon (I hope)...

Details

- notification for comment with ID 2538878352 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 18 out of 18 (18 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d8f930f308ca2004cfc4745db3de97b6 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 12, 2024

@boegelbot please test @ jsc-zen3

@smoors smoors added this to the release after 4.9.4 milestone Dec 12, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2024

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22005 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22005 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5433

Test results coming soon (I hope)...

Details

- notification for comment with ID 2539153881 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 12, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 18 out of 18 (18 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/d447ead89aaaa670301453dc2704b895 for a full test report.

smoors
smoors approved these changes Dec 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 12, 2024

Going in, thanks @Micket!

@smoors smoors merged commit 29a3a8c into easybuilders:develop Dec 12, 2024
@Micket Micket deleted the 20241210233647_new_pr_pkgconf180 branch February 27, 2025 17:46
@boegel boegel changed the title Set PKG_CONFIG variable to pkgconf Set $PKG_CONFIG in pkgconf modules Mar 18, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Micket @smoors @boegelbot @boegel