Skip to content

{bio}[GCCcore/13.3.0] rDock v24.03.192#22012

Merged
smoors merged 2 commits intoeasybuilders:developfrom
sassy-crick:20241211174910_new_pr_rDock2403192
Dec 14, 2024
Merged

{bio}[GCCcore/13.3.0] rDock v24.03.192#22012
smoors merged 2 commits intoeasybuilders:developfrom
sassy-crick:20241211174910_new_pr_rDock2403192

Conversation

@sassy-crick
Copy link
Copy Markdown
Collaborator

(created using eb --new-pr)

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@sassy-crick: Request for testing this PR well received on login1

PR test command 'EB_PR=22012 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22012 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14852

Test results coming soon (I hope)...

Details

- notification for comment with ID 2536806116 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/54fd07468c84c27c627eba17ee322759 for a full test report.

sanity_check_paths = {
'files': ['bin/rbhtfinder', 'bin/sdreport', 'bin/run_rbdock.pl', 'lib/libRbt.so'],
'dirs': ['include'],
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some sanity_check_commands here? for example

sanity_check_commands = [
    'rbdock --help',
    'rbcavity --help',
]

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for that, this has slipped through. Thanks for finding that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries, no need to apologize :)

@sassy-crick
Copy link
Copy Markdown
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@sassy-crick: Request for testing this PR well received on login1

PR test command 'EB_PR=22012 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22012 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14864

Test results coming soon (I hope)...

Details

- notification for comment with ID 2541940698 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/61650edf8ad7b99a7d8a7722f8b13f32 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 14, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22012 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22012 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5443

Test results coming soon (I hope)...

Details

- notification for comment with ID 2543196552 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/964990b33fe7ce042fd2db8a67530a5d for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the release after 4.9.4 milestone Dec 14, 2024
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 14, 2024

Going in, thanks @sassy-crick!

@smoors smoors merged commit 81cf52a into easybuilders:develop Dec 14, 2024
@sassy-crick sassy-crick deleted the 20241211174910_new_pr_rDock2403192 branch January 20, 2025 12:37
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants