Skip to content

add patch for Autoconf to improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64 systems#22173

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
Thyre:20250117112005_new_pr_Autoconf271
Jan 18, 2025
Merged

add patch for Autoconf to improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64 systems#22173
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
Thyre:20250117112005_new_pr_Autoconf271

Conversation

@Thyre
Copy link
Copy Markdown
Collaborator

@Thyre Thyre commented Jan 17, 2025

(created using eb --new-pr)

@Thyre
Improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64…
f69fc11 
… systems, causing application builds to abort when Fortran to C linking is used
@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Jan 17, 2025

Some EasyConfigs, like easybuild/easyconfigs/a/Autoconf/Autoconf-2.71.eb had a different checksum than I got when downloading the sources (and were used on other autoconf 2.71 EasyConfigs). Also updated these checksums so that they're all consistent.

@Thyre Thyre changed the title Improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64 systems, causing application builds to abort when Fortran to C linking is used Autoconf: Improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64 systems, causing application builds to abort when Fortran to C linking is used Jan 17, 2025
@Thyre Thyre changed the title Autoconf: Improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64 systems, causing application builds to abort when Fortran to C linking is used Autoconf: Improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64 systems Jan 17, 2025
@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Jan 17, 2025

Test report by @Thyre
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
Linux - Linux Arch Linux UNKNOWN, x86_64, AMD Ryzen 7 7800X3D 8-Core Processor, 1 x NVIDIA NVIDIA GeForce RTX 3070, 565.77, Python 3.13.1
See https://gist.github.com/Thyre/9661cca4759250d4b0a8bc36313afb2b for a full test report.

@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Jan 17, 2025

@boegelbot please test @ jsc-zen3

@SebastianAchilles SebastianAchilles added this to the release after 4.9.4 milestone Jan 17, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 17, 2025

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22173 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22173 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5546

Test results coming soon (I hope)...

Details

- notification for comment with ID 2598036137 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 17, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/c9f5d9c509218727c7812d5a371ac8c9 for a full test report.

@SebastianAchilles SebastianAchilles added enhancement aarch64 Related to Arm 64-bit (aarch64) labels Jan 17, 2025
@Thyre
Copy link
Copy Markdown
Collaborator Author

Thyre commented Jan 17, 2025

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 17, 2025

@Thyre: Request for testing this PR well received on login1

PR test command 'EB_PR=22173 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_22173 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14950

Test results coming soon (I hope)...

Details

- notification for comment with ID 2598103755 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 17, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/048d8364d0fc58f1f8f491b76e3c1d21 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Jan 17, 2025

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
bwd-rockylinux-95 - Linux Rocky Linux 9.5 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), 2 x NVIDIA NVIDIA GeForce GTX 1060 6GB, 535.216.03, Python 3.9.21
See https://gist.github.com/SebastianAchilles/2be566399f41c1512fb7b861b8f024d1 for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Jan 17, 2025

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
zen2-rockylinux-810 - Linux Rocky Linux 8.10, x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/SebastianAchilles/9bd987373f81ebda7fa34889e82a9aa9 for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Jan 18, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Jan 18, 2025

Going in, thanks @Thyre!

@SebastianAchilles SebastianAchilles merged commit 69f22a4 into easybuilders:develop Jan 18, 2025
@boegel boegel changed the title Autoconf: Improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64 systems add patch for Autoconf to improve handling for 'llc' flags appearing e.g. with NVHPC on aarch64 systems Mar 18, 2025
@boegel boegel removed the change label Mar 18, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
@Thyre Thyre deleted the 20250117112005_new_pr_Autoconf271 branch August 10, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

aarch64 Related to Arm 64-bit (aarch64) enhancement

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Thyre @boegelbot @SebastianAchilles @boegel