Skip to content

{bio}[foss/2024a] YaHS 1.2.2#22199

Merged
smoors merged 6 commits intoeasybuilders:developfrom
pescobar:yahs
Jan 23, 2025
Merged

{bio}[foss/2024a] YaHS 1.2.2#22199
smoors merged 6 commits intoeasybuilders:developfrom
pescobar:yahs

Conversation

@pescobar
Copy link
Copy Markdown
Member

@pescobar pescobar commented Jan 22, 2025

No description provided.

@github-actions github-actions Bot added the new label Jan 22, 2025
smoors
smoors reviewed Jan 23, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/y/YaHS/YaHS-1.2.2-foss-2024a.eb
sanity_check_paths = {
'files': ["bin/yahs", "bin/juicer", "bin/agp_to_fasta"],
'dirs': [],
}
Copy link
Copy Markdown
Contributor

@smoors smoors Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some sanity_check_commands here? for example

sanity_check_commands = ['yahs -?']

Copy link
Copy Markdown
Member Author

@pescobar pescobar Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 23, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 23, 2025

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22199 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22199 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5584

Test results coming soon (I hope)...

Details

- notification for comment with ID 2610664447 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 23, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/43f0d4df1ca74abbe860a725dd3413f5 for a full test report.

@smoors smoors added this to the release after 4.9.4 milestone Jan 23, 2025
smoors
smoors approved these changes Jan 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Jan 23, 2025

Going in, thanks @pescobar!

@smoors smoors merged commit 2345ba5 into easybuilders:develop Jan 23, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pescobar @smoors @boegelbot @boegel