{lib}[GCCcore/12.3.0] squashfs-tools v4.6.1 by robertosussex · Pull Request #22213 · easybuilders/easybuild-easyconfigs

robertosussex · 2025-01-24T19:24:10Z

(created using eb --new-pr)

smoors

@robertosussex thanks a lot for your first contribution!

i've added a number of suggestions to make the recipe even better.

robertosussex · 2025-01-25T22:13:12Z

Dear @smoors, Thank you!I have changed according to your suggestions. However, the /include directory is not included using the modified .eb fileThe:+files_to_copy = [ + (['squashfs-tools/*'], 'bin'), + (['squashfs-tools/*.h'], 'include'), +]option files_to_copy is not allowed using the 'ConfigureMake' EasyBlock. So, I am trying to figure out how to do it with 'ConfigureMake'Suggestions? RegardsRoberto S.(robertosussex) Il sabato 25 gennaio 2025 alle ore 08:59:00 GMT, Sam Moors ***@***.***> ha scritto: @smoors requested changes on this pull request. @robertosussex thanks a lot for your first contribution! i've added a number of suggestions to make the recipe even better. In easybuild/easyconfigs/s/squashfs-tools/squashfs-tools-4.6.1-GCCcore-12.3.0.eb:

@@ -0,0 +1,29 @@

+easyblock = 'MakeCp' + +name = 'squashfs-tools' +version = '4.6.1' + +homepage = ' https://github.com/plougher/squashfs-tools' +description = """squashfs-fuse""" can you put something more descriptive here? ⬇️ Suggested change-description = """squashfs-fuse""" +description = """tools to create and extract Squashfs filesystems""" In easybuild/easyconfigs/s/squashfs-tools/squashfs-tools-4.6.1-GCCcore-12.3.0.eb:

@@ -0,0 +1,29 @@

+easyblock = 'MakeCp' + +name = 'squashfs-tools' +version = '4.6.1' + +homepage = ' https://github.com/plougher/squashfs-tools' +description = """squashfs-fuse""" + +toolchain = {'name': 'GCCcore', 'version': '12.3.0'} + +source_urls = ['https://github.com/plougher/squashfs-tools/archive'] +sources = ['master.tar.gz'] we try to avoid using a branch as much as possible for reproducibility, always use a release, a tag, or a commit: ⬇️ Suggested change-sources = ['master.tar.gz'] +sources = ['%(version)s.tar.gz'] you also have to add a checksum. simplest way to do that is with eb squashfs-tools-4.6.1-GCCcore-12.3.0 --inject-checksums In easybuild/easyconfigs/s/squashfs-tools/squashfs-tools-4.6.1-GCCcore-12.3.0.eb:

@@ -0,0 +1,29 @@

+easyblock = 'MakeCp' + +name = 'squashfs-tools' +version = '4.6.1' + +homepage = ' https://github.com/plougher/squashfs-tools' +description = """squashfs-fuse""" + +toolchain = {'name': 'GCCcore', 'version': '12.3.0'} + +source_urls = ['https://github.com/plougher/squashfs-tools/archive'] +sources = ['master.tar.gz'] + +build_cmd = "cd squashfs-tools ; make" we can use the start_dir parameter instead of the cd cmd. we will also skip the configure step here and set the install prefix: ⬇️ Suggested change-build_cmd = "cd squashfs-tools ; make" +start_dir = "squashfs-tools" + +skipsteps = ['configure'] + +installopts = 'INSTALL_PREFIX=%(installdir)s' In easybuild/easyconfigs/s/squashfs-tools/squashfs-tools-4.6.1-GCCcore-12.3.0.eb:

@@ -0,0 +1,29 @@

+easyblock = 'MakeCp' the Makefile has an install rule, so we can use ConfigureMake here and skip the configure step: ⬇️ Suggested change-easyblock = 'MakeCp' +easyblock = 'ConfigureMake' In easybuild/easyconfigs/s/squashfs-tools/squashfs-tools-4.6.1-GCCcore-12.3.0.eb:

+sources = ['master.tar.gz']

+ +build_cmd = "cd squashfs-tools ; make" + + +files_to_copy = [ + (['squashfs-tools/*'], 'bin'), + (['squashfs-tools/*.h'], 'include'), +] + +sanity_check_paths = { + 'files': ['bin/mksquashfs', 'bin/unsquashfs'], + 'dirs': [], +} + +modextrapaths = {'PATH': ' '} this should be removed as the binaries are in bin, which is automatically added to the PATH by EB: ⬇️ Suggested change-modextrapaths = {'PATH': ' '} — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

smoors · 2025-01-26T08:10:51Z

files_to_copy is not allowed using the 'ConfigureMake' EasyBlock. So, I am trying to figure out how to do it with 'ConfigureMake'Suggestions?

you can do it like this:

postinstallcmds = ['mkdir %(installdir)s/include && cp *.h %(installdir)s/include']

i'm curious though, why do you need those header files?

robertosussex · 2025-01-26T11:17:03Z

That looks brilliant!Will do, thanks.R. Il domenica 26 gennaio 2025 alle ore 08:11:14 GMT, Sam Moors ***@***.***> ha scritto: files_to_copy is not allowed using the 'ConfigureMake' EasyBlock. So, I am trying to figure out how to do it with 'ConfigureMake'Suggestions? you can do it like this: postinstallcmds = ['mkdir %(installdir)s/include && cp *.h %(installdir)s/include'] — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

robertosussex · 2025-01-26T11:48:25Z

I apologise for being a beginner! :-) eb --github-user robertosussex --update-pr 22213 --pr-target-repo xxxxxxxx What do I put for target repo? ThanksRoberto Il domenica 26 gennaio 2025 alle ore 08:11:14 GMT, Sam Moors ***@***.***> ha scritto: files_to_copy is not allowed using the 'ConfigureMake' EasyBlock. So, I am trying to figure out how to do it with 'ConfigureMake'Suggestions? you can do it like this: postinstallcmds = ['mkdir %(installdir)s/include && cp *.h %(installdir)s/include'] — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

smoors · 2025-01-26T12:24:35Z

eb --github-user robertosussex --update-pr 22213 --pr-target-repo xxxxxxxx What do I put for target repo?

the default is easybuild-easyconfigs, so you don't need that option

robertosussex · 2025-01-26T12:29:05Z

Almost there !!! :-)PATH required? R. Il domenica 26 gennaio 2025 alle ore 12:24:58 GMT, Sam Moors ***@***.***> ha scritto: eb --github-user robertosussex --update-pr 22213 --pr-target-repo xxxxxxxx What do I put for target repo? the default is easybuild-easyconfigs, so you don't need that option — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

robertosussex · 2025-01-26T12:45:23Z

THis worked! I guess I have to set the defaults somewhere? Many thanks Roberto Il domenica 26 gennaio 2025 alle ore 12:24:58 GMT, Sam Moors ***@***.***> ha scritto: eb --github-user robertosussex --update-pr 22213 --pr-target-repo xxxxxxxx What do I put for target repo? the default is easybuild-easyconfigs, so you don't need that option — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

smoors · 2025-01-26T12:53:55Z

looks good!
i made a small commit, switching the order of 2 parameters. the recommendation is to list them in order of usage by BE.

robertosussex · 2025-01-26T12:55:48Z

So it is done right? :-)RegardsR. Il domenica 26 gennaio 2025 alle ore 12:54:18 GMT, Sam Moors ***@***.***> ha scritto: looks good! i made a small commit, switching the order of 2 parameters. the recommendation is to list them in order of usage by BE. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

…4.6.1-GCCcore-12.3.0.eb

smoors · 2025-01-26T12:58:11Z

i also removed the old version, because you had 2 files in the PR

robertosussex · 2025-01-26T13:20:01Z

How does the update to the main easyconfig repo work?Thank you very very much for your help :-)Roberto Il domenica 26 gennaio 2025 alle ore 12:58:35 GMT, Sam Moors ***@***.***> ha scritto: i also removed the old version, because you had 2 files in the PR — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

github-actions · 2025-01-26T13:22:47Z

Updated software `squashfs-tools-4.6.1-GCCcore-12.3.0.eb`

Diff against squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb

easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb

diff --git a/easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb b/easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-4.6.1-GCCcore-12.3.0.eb
index ddea0944be..dcd059aba1 100644
--- a/easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb
+++ b/easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-4.6.1-GCCcore-12.3.0.eb
@@ -11,9 +11,6 @@ toolchain = {'name': 'GCCcore', 'version': '12.3.0'}
 
 source_urls = ['https://github.com/plougher/squashfs-tools/archive/refs/tags/']
 sources = ['%(version)s.tar.gz']
-checksums = ['94201754b36121a9f022a190c75f718441df15402df32c2b520ca331a107511c']
-
-builddependencies = [('binutils', '2.42')]
 
 start_dir = "squashfs-tools"

Updated software `squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb`

Diff against squashfs-tools-4.6.1-GCCcore-12.3.0.eb

easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-4.6.1-GCCcore-12.3.0.eb

diff --git a/easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-4.6.1-GCCcore-12.3.0.eb b/easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb
index dcd059aba1..ddea0944be 100644
--- a/easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-4.6.1-GCCcore-12.3.0.eb
+++ b/easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb
@@ -11,6 +11,9 @@ toolchain = {'name': 'GCCcore', 'version': '12.3.0'}
 
 source_urls = ['https://github.com/plougher/squashfs-tools/archive/refs/tags/']
 sources = ['%(version)s.tar.gz']
+checksums = ['94201754b36121a9f022a190c75f718441df15402df32c2b520ca331a107511c']
+
+builddependencies = [('binutils', '2.42')]
 
 start_dir = "squashfs-tools"

…T-4.6.1-GCCcore-12.3.0.eb

….1-GCCcore-12.3.0.eb

smoors · 2025-01-26T13:30:23Z

@robertosussex i also added the binutils build dep, which is required for GCCcore toolchain, added the checksum with --inject-checksums, and removed the old files with TEST in their name.. :)

should be ready for CI now

robertosussex · 2025-01-26T13:43:37Z

Many thanks guys!

smoors · 2025-01-26T15:28:49Z

@boegelbot please test @ jsc-zen3

boegelbot · 2025-01-26T15:30:09Z

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22213 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22213 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 5603

Test results coming soon (I hope)...

Details

- notification for comment with ID 2614469626 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-01-26T15:30:43Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/9f4b0772ea21d2002a2b9989f9243cfe for a full test report.

smoors

lgtm

smoors · 2025-01-26T15:37:09Z

Going in, thanks @robertosussex!

robertosussex · 2025-01-26T15:41:48Z

👍R. Il domenica 26 gennaio 2025 alle ore 15:37:31 GMT, Sam Moors ***@***.***> ha scritto: Merged #22213 into develop. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

adding easyconfigs: squashfs-tools-4.6.1-GCCcore-12.3.0.eb

906f5fd

github-actions Bot added the new label Jan 24, 2025

smoors requested changes Jan 25, 2025

View reviewed changes

Improved .eb

2f1e9f5

smoors reviewed Jan 26, 2025

View reviewed changes

Comment thread easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb Outdated

switch order of parameters

5c60c9f

smoors added 2 commits January 26, 2025 13:56

delete old file

c975c03

Rename squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb to squashfs-tools-…

c2fac79

…4.6.1-GCCcore-12.3.0.eb

add missing builddep and checksum

29e2b5b

github-actions Bot added the update label Jan 26, 2025

github-actions Bot removed the new label Jan 26, 2025

remove TEST from software name

624de37

github-actions Bot added the new label Jan 26, 2025

Delete easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-TES…

d8b38e4

…T-4.6.1-GCCcore-12.3.0.eb

github-actions Bot removed the update label Jan 26, 2025

Delete easybuild/easyconfigs/s/squashfs-tools-TEST/squashfs-tools-4.6…

579a885

….1-GCCcore-12.3.0.eb

fix binutils version

2c48f86

smoors added this to the release after 4.9.4 milestone Jan 26, 2025

smoors approved these changes Jan 26, 2025

View reviewed changes

smoors merged commit e9389a5 into easybuilders:develop Jan 26, 2025

boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025

Conversation

robertosussex commented Jan 24, 2025

Uh oh!

smoors left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertosussex commented Jan 25, 2025 via email

Uh oh!

smoors commented Jan 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robertosussex commented Jan 26, 2025 via email

Uh oh!

robertosussex commented Jan 26, 2025 via email

Uh oh!

smoors commented Jan 26, 2025

Uh oh!

robertosussex commented Jan 26, 2025 via email

Uh oh!

robertosussex commented Jan 26, 2025 via email

Uh oh!

Uh oh!

smoors commented Jan 26, 2025

Uh oh!

robertosussex commented Jan 26, 2025 via email

Uh oh!

smoors commented Jan 26, 2025

Uh oh!

robertosussex commented Jan 26, 2025 via email

Uh oh!

github-actions Bot commented Jan 26, 2025

Updated software squashfs-tools-4.6.1-GCCcore-12.3.0.eb

Updated software squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb

Uh oh!

smoors commented Jan 26, 2025

Uh oh!

robertosussex commented Jan 26, 2025

Uh oh!

smoors commented Jan 26, 2025

Uh oh!

boegelbot commented Jan 26, 2025

Uh oh!

boegelbot commented Jan 26, 2025

Uh oh!

smoors left a comment

Choose a reason for hiding this comment

Uh oh!

smoors commented Jan 26, 2025

Uh oh!

robertosussex commented Jan 26, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

smoors commented Jan 26, 2025 •

edited

Loading

Updated software `squashfs-tools-4.6.1-GCCcore-12.3.0.eb`

Updated software `squashfs-tools-TEST-4.6.1-GCCcore-12.3.0.eb`