Skip to content

unset $BUILD_VERSION set by torchvision easyblock in preinstallopts for torchaudio in easyconfigs for PyTorch-bundle 2.1.2#22258

Merged
boegel merged 7 commits intoeasybuilders:developfrom
pavelToman:patch-7
Feb 13, 2025
Merged

unset $BUILD_VERSION set by torchvision easyblock in preinstallopts for torchaudio in easyconfigs for PyTorch-bundle 2.1.2#22258
boegel merged 7 commits intoeasybuilders:developfrom
pavelToman:patch-7

Conversation

@pavelToman
Copy link
Copy Markdown
Collaborator

@pavelToman pavelToman commented Feb 4, 2025

There is problem with version of torchaudio - it has version instead of 2.1.2 in easyconfig, but it not get right version.
See: easybuilders/easybuild-framework#4706

@github-actions github-actions Bot added the change label Feb 4, 2025
@pavelToman
Copy link
Copy Markdown
Collaborator Author

pavelToman commented Feb 4, 2025

@boegelbot please test @ jsc-zen3-a100

@pavelToman pavelToman mentioned this pull request Feb 4, 2025
Closed
2 tasks
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 4, 2025

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22258 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22258 --ntasks=8 --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5662

Test results coming soon (I hope)...

Details

- notification for comment with ID 2634531572 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 4, 2025

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/ff014d810a069026aa2d6fb061fb922e for a full test report.

@pavelToman pavelToman mentioned this pull request Feb 4, 2025
Merged
@github-actions github-actions Bot added the change label Feb 4, 2025
boegel
boegel requested changes Feb 12, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/p/PyTorch-bundle/PyTorch-bundle-2.1.2-foss-2023a-CUDA-12.1.1.eb Outdated
boegel
boegel requested changes Feb 12, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/p/PyTorch-bundle/PyTorch-bundle-2.1.2-foss-2023a.eb Outdated
@boegel boegel changed the title Quick-fix torchaudio version bug unset $BUILD_VERSION set by torchvision easyblock in preinstallopts for torchaudio in easyconfigs for PyTorch-bundle 2.1.2 Feb 12, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 12, 2025

@boegelbot please test @ jsc-zen3-a100

@boegel boegel added this to the release after 4.9.4 milestone Feb 12, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 12, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22258 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22258 --ntasks=8 --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5702

Test results coming soon (I hope)...

Details

- notification for comment with ID 2654638682 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 12, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/8e530f40b5ad93fd1991641ce28705e3 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 13, 2025

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3901.accelgor.os - Linux RHEL 9.4, x86_64, AMD EPYC 7413 24-Core Processor (zen3), 1 x NVIDIA NVIDIA A100-SXM4-80GB, 555.42.06, Python 3.9.18
See https://gist.github.com/boegel/ea3b0b4d158bfc75ef6a19f5b722cea9 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 13, 2025

Going in, thanks @pavelToman!

@boegel boegel merged commit e35132d into easybuilders:develop Feb 13, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
@boegel boegel mentioned this pull request May 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pavelToman @boegelbot @boegel