rename patch files for OpenFOAM according to (our) 'standards'#2226
rename patch files for OpenFOAM according to (our) 'standards'#2226boegel merged 1 commit intoeasybuilders:developfrom
Conversation
|
lgtm |
|
Easyconfigs unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyconfigs-pr-builder/5342/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Thanks for the review @wpoely86! |
rename patch files for OpenFOAM according to (our) 'standards'
|
Why were the patches not copied rather than renamed? This breaks working eb files for us...and took a while to solve |
|
@ocaisa: at some point, we need to clean up mistakes we made in the past and work towards something 'uniform'... Thanks for bringing this up though. How did the problem manifest itself, and why did it take you a while to solve? This also goes back to your feature request to make sure everything that is needed to reproduce a build is archived somewhere (potentially including the used easyblock(s)...). |
|
It wasn't a guru like me who was solving it which was maybe why it took a while :) They tried to reinstall an existing eb file with EB 2.5 but the patch file could no longer be found. I silently upgrade EB so they had no way of knowing the version had changed. |
|
Where did you get the easyconfig file from? The easyconfig archive maintained by EasyBuild itself? Or an existing install directory? |
|
Custom easyconfig with custom toolchain and configuration (used for a previous installation) |
|
In that case, either never removing the patch files or copying them next to the sources could have saved you... |
|
Yup, exactly |
workaround for easybuilders/easybuild-framework#1516, so #2023 and #2048 can be properly tested via
--from-pr