{math}[foss/2023a] CHARM++ v8.0.0 by robertosussex · Pull Request #22281 · easybuilders/easybuild-easyconfigs

robertosussex · 2025-02-09T14:56:11Z

(created using eb --new-pr)

boegel · 2025-02-11T07:20:32Z

@robertosussex There's two issues to fix:

Checksums missing for one or more sources/patches in CHARMPP-8.0.0-foss-2023a.eb: found 1 sources + 0 patches vs 0 checksums
There shouldn't be any code style errors (and/or warnings), found 12:

Details

/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:7:121: E501 line too long (262 > 120 characters)
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:18:12: E231 missing whitespace after ','
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:21:29: E225 missing whitespace around operator
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:23:16: E225 missing whitespace around operator
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:25:12: E225 missing whitespace around operator
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:33:27: E231 missing whitespace after ','
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:33:42: E231 missing whitespace after ','
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:33:56: E231 missing whitespace after ','
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:33:70: E231 missing whitespace after ','
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:33:85: E231 missing whitespace after ','
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:34:19: E231 missing whitespace after ','
/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:38:1: W391 blank line at end of file

robertosussex · 2025-02-11T11:35:24Z

Added checksums. Removed blank line. Not sure about white spaces.

robertosussex · 2025-02-11T15:42:16Z

I have tried in different ways. Not sure how to remove the errors.

robertosussex · 2025-02-11T17:46:21Z

Now they passed!

robertosussex · 2025-02-12T12:00:09Z

What is the next step?

robertosussex · 2025-02-21T14:59:45Z

Hi there, I was wondering how long it is going to take before the merging is allowed? :-)Kind regards and thanks Roberto Il mercoledì 12 febbraio 2025 alle ore 19:46:10 GMT, Kenneth Hoste ***@***.***> ha scritto: @boegel requested changes on this pull request. In easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:

+configure_without_installdir = "TRUE"

+ +configure_cmd = ' ' This suggests you want to actually skip the configure step, which is better done with: ⬇️ Suggested change-configure_without_installdir = "TRUE" - -configure_cmd = ' ' +skipsteps = ['configure'] In easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:

+install_cmd = ' mkdir %(installdir)s/bin %(installdir)s/include %(installdir)s/lib'

+install_cmd += ' ; cp -R bin/* %(installdir)s/bin ' +install_cmd += ' ; cp -R include/* %(installdir)s/include ' +install_cmd += ' ; cp -R lib/* %(installdir)s/lib' no need to pre-create the subdirectories: ⬇️ Suggested change-install_cmd = ' mkdir %(installdir)s/bin %(installdir)s/include %(installdir)s/lib' -install_cmd += ' ; cp -R bin/* %(installdir)s/bin ' -install_cmd += ' ; cp -R include/* %(installdir)s/include ' -install_cmd += ' ; cp -R lib/* %(installdir)s/lib' +install_cmd = "cp -a bin include lib %(installdir)s/" In easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:

+

+configure_without_installdir = "TRUE" + +configure_cmd = ' ' + +build_cmd = ' export MPICXX=mpicxx ; ./build charm++ mpi-linux-x86_64 mpicxx --with-production --force ' + +install_cmd = ' mkdir %(installdir)s/bin %(installdir)s/include %(installdir)s/lib' +install_cmd += ' ; cp -R bin/* %(installdir)s/bin ' +install_cmd += ' ; cp -R include/* %(installdir)s/include ' +install_cmd += ' ; cp -R lib/* %(installdir)s/lib' + +sanity_check_paths = { + 'files': ['bin/charmc', 'bin/charmrun', 'bin/charmxi', 'bin/ckhello', 'bin/conv-cpm', 'bin/testrun'], + 'dirs': ['bin', 'lib'], +} add sanity check command (also useful with eb --sanity-check-only after installing the module) ⬇️ Suggested change-} +} + +sanity_check_commands = ["charmrun --help"] In easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:

+homepage = 'https://charmplusplus.org/tutorial/'

+ ⬇️ Suggested change-homepage = 'https://charmplusplus.org/tutorial/' - + +homepage = 'https://charmplusplus.org' In easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:

@@ -0,0 +1,41 @@

+easyblock = 'ConfigureMake' + +name = 'CHARMPP' @robertosussex We strongly prefer sticking to the "official" software name, which in this case seems to be Charm++. In easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:

+

+source_urls = ['http://charm.cs.illinois.edu/distrib/'] +sources = ['charm-%(version)s.tar.gz'] +checksums = ['e30fc1e921e5cbf3406e792d5b0ca5f211c5d8ffbfc56e56d5501d8118abcaf6'] + +dependencies = [ + ('CMake', '3.26.3'), + ('Tcl', '8.6.13'), + ('FFTW', '3.3.10'), +] + +configure_without_installdir = "TRUE" + +configure_cmd = ' ' + +build_cmd = ' export MPICXX=mpicxx ; ./build charm++ mpi-linux-x86_64 mpicxx --with-production --force ' no need to set $MPICXX: ⬇️ Suggested change-build_cmd = ' export MPICXX=mpicxx ; ./build charm++ mpi-linux-x86_64 mpicxx --with-production --force ' +build_cmd = "./build charm++ mpi-linux-x86_64 mpicxx --with-production --force " In easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb:

+

+configure_cmd = ' ' + +build_cmd = ' export MPICXX=mpicxx ; ./build charm++ mpi-linux-x86_64 mpicxx --with-production --force ' + +install_cmd = ' mkdir %(installdir)s/bin %(installdir)s/include %(installdir)s/lib' +install_cmd += ' ; cp -R bin/* %(installdir)s/bin ' +install_cmd += ' ; cp -R include/* %(installdir)s/include ' +install_cmd += ' ; cp -R lib/* %(installdir)s/lib' + +sanity_check_paths = { + 'files': ['bin/charmc', 'bin/charmrun', 'bin/charmxi', 'bin/ckhello', 'bin/conv-cpm', 'bin/testrun'], + 'dirs': ['bin', 'lib'], +} + +moduleclass = 'math' ⬇️ Suggested change-moduleclass = 'math' +moduleclass = 'lang' — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

robertosussex · 2025-03-02T12:39:52Z

The changes have been implemented and all checks have passed. Is Merging possible?

robertosussex · 2025-04-02T16:09:17Z

updates on this?

robertosussex · 2025-07-23T16:49:38Z

Any chance we could have this merged?
Kind regards
Roberto

Thyre · 2025-08-18T13:11:05Z

This PR now contains the original EasyConfigs, and the one with the changes after the review.
The old one should be dropped.

robertosussex · 2025-08-18T13:26:17Z

Hi, Thanks. Not sure what you are asking me to do :-) RegardsRoberto Yahoo Mail: Search, organise, conquer On Mon, 18 Aug 2025 at 14:11, Jan André ***@***.***> wrote: Thyre left a comment (easybuilders/easybuild-easyconfigs#22281) This PR now contains the original EasyConfigs, and the one with the changes after the review. The old one should be dropped. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

robertosussex · 2025-08-18T16:25:31Z

Hi, I am not sure how to do it :-(I imagine you are referring to remove every one but the last? Please adviceRoberto Il lunedì 18 agosto 2025 alle ore 14:11:27 GMT+1, Jan André Reuter ***@***.***> ha scritto: Thyre left a comment (easybuilders/easybuild-easyconfigs#22281) This PR now contains the original EasyConfigs, and the one with the changes after the review. The old one should be dropped. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Thyre · 2025-08-18T16:29:52Z

Right now, your PR includes two files:

easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb
easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb

The latter is the file you've initially created for the PR, the former is the file after you addressed the review by Kenneth.
Since we don't need both, you can just remove the second file (easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb) from this PR. Then,we can continue with testing and so on to get this merged at some point.

Deleted one of the files

robertosussex · 2025-08-18T16:47:06Z

OK I have deleted the CHARMPP one.

Thyre · 2025-08-18T16:50:13Z

There are three little style issues:

./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:9:84: W291 trailing whitespace
./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:10:49: W291 trailing whitespace
./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:11:73: W291 trailing whitespace

Those should be straight-forward to fix though

robertosussex · 2025-08-18T16:56:38Z

will get to itR. Il lunedì 18 agosto 2025 alle ore 17:50:37 GMT+1, Jan André Reuter ***@***.***> ha scritto: Thyre left a comment (easybuilders/easybuild-easyconfigs#22281) There are three little style issues: ./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:9:84: W291 trailing whitespace ./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:10:49: W291 trailing whitespace ./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:11:73: W291 trailing whitespace Those should be straight-forward to fix though — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

robertosussex · 2025-08-18T17:12:15Z

Isnt that an issue with Python though?There is nothing wrong with description = """Charm++ is a message-passing parallel language and runtime system. It is implemented as a set of libraries for C++. It is efficient, and is portable to a wide variety of parallel machines. or is there? RegardsRoberto Il lunedì 18 agosto 2025 alle ore 17:50:37 GMT+1, Jan André Reuter ***@***.***> ha scritto: Thyre left a comment (easybuilders/easybuild-easyconfigs#22281) There are three little style issues: ./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:9:84: W291 trailing whitespace ./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:10:49: W291 trailing whitespace ./easybuild/easyconfigs/c/CHARM++/CHARM++-8.0.0-foss-2023a.eb:11:73: W291 trailing whitespace Those should be straight-forward to fix though — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Thyre · 2025-08-18T17:16:44Z

Like mentioned by the CI job, there are white spaces at the end of the three lines in the description. It doesn't matter that they're included in the string. They exist, and therefore fail our linter.

robertosussex · 2025-08-18T17:28:35Z

OK, submitting updated .ebR. Il lunedì 18 agosto 2025 alle ore 18:17:09 GMT+1, Jan André Reuter ***@***.***> ha scritto: Thyre left a comment (easybuilders/easybuild-easyconfigs#22281) Like mentioned by the CI job, there are white spaces at the end of the three lines in the description. It doesn't matter that they're included in the string. They exist, and therefore fail our linter. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

robertosussex · 2025-08-18T18:06:20Z

I guess I have to use --update-pr or?R. Il lunedì 18 agosto 2025 alle ore 18:17:09 GMT+1, Jan André Reuter ***@***.***> ha scritto: Thyre left a comment (easybuilders/easybuild-easyconfigs#22281) Like mentioned by the CI job, there are white spaces at the end of the three lines in the description. It doesn't matter that they're included in the string. They exist, and therefore fail our linter. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Thyre · 2025-08-18T18:10:57Z

You can use --update-pr, do it via git or even via GitHub itself.
One of the first two options is probably the easiest to do.

robertosussex · 2025-08-18T18:15:08Z

With --update-pr I hiturllib.error.URLError: <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1002)> How do I do it from GitHub? R. Il lunedì 18 agosto 2025 alle ore 19:11:19 GMT+1, Jan André Reuter ***@***.***> ha scritto: Thyre left a comment (easybuilders/easybuild-easyconfigs#22281) You can use --update-pr, do it via git or even via GitHub itself. One of the first two options is probably the easiest to do. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

Removed trailing spaces

robertosussex · 2025-08-18T18:16:58Z

Ok done it from GitHub

robertosussex · 2025-08-18T18:28:42Z

ALL check have passed

Thyre · 2025-08-18T18:29:13Z

@boegelbot please test @ jsc-zen3

robertosussex · 2025-08-18T18:29:23Z

All checks passedRegardsRoberto Il lunedì 18 agosto 2025 alle ore 19:11:19 GMT+1, Jan André Reuter ***@***.***> ha scritto: Thyre left a comment (easybuilders/easybuild-easyconfigs#22281) You can use --update-pr, do it via git or even via GitHub itself. One of the first two options is probably the easiest to do. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

boegelbot · 2025-08-18T18:30:09Z

@Thyre: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22281 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22281 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 7685

Test results coming soon (I hope)...

Details

- notification for comment with ID 3197976663 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

robertosussex · 2025-08-18T18:33:54Z

Thanks

boegelbot · 2025-08-18T18:37:06Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/7aa485d688cd691f95a1f3f78a7d6e78 for a full test report.

robertosussex · 2025-08-18T18:53:35Z

Great!

verdurin · 2025-08-18T19:31:08Z

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.11.13
See https://gist.github.com/verdurin/c2b6397341676465ca4c1ff80b058796 for a full test report.

boegel

lgtm

boegel · 2025-08-18T20:27:40Z

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3513.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/9f16b6122064d9efc3ce8e52d9242c4a for a full test report.

boegel · 2025-08-18T20:27:54Z

Going in, thanks @robertosussex!

robertosussex · 2025-08-18T20:54:02Z

Great!R. Il lunedì 18 agosto 2025 alle ore 21:28:50 GMT+1, Kenneth Hoste ***@***.***> ha scritto: Merged #22281 into develop. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

adding easyconfigs: CHARMPP-8.0.0-foss-2023a.eb

d5afcc9

github-actions Bot added the new label Feb 9, 2025

Improved .eb

3cb891a

robertosussex added 4 commits February 11, 2025 11:49

Improved .eb

c027ffc

Improved .eb

85ab2c3

Improved .eb

41d05ad

Improved .eb

05474e6

Improved .eb

be99544

boegel requested changes Feb 12, 2025

View reviewed changes

boegel added this to the 4.x milestone Feb 12, 2025

Improved .eb

545dbaa

robertosussex requested a review from boegel February 14, 2025 14:42

Improved charm++.....eb

8a4fe8c

Thyre added the 2023a label Aug 18, 2025

Delete easybuild/easyconfigs/c/CHARMPP/CHARMPP-8.0.0-foss-2023a.eb

c86bc61

Deleted one of the files

Update CHARM++-8.0.0-foss-2023a.eb

bf54c8c

Removed trailing spaces

Thyre added the ready-to-review label Aug 18, 2025

boegel approved these changes Aug 18, 2025

View reviewed changes

boegel modified the milestones: 5.x, next release (5.1.2) Aug 18, 2025

boegel merged commit a7b225f into easybuilders:develop Aug 18, 2025
5 checks passed

Thyre removed the ready-to-review label Aug 19, 2025

boegel changed the title ~~{math}[foss/2023a] CHARMPP v8.0.0~~ {math}[foss/2023a] CHARM++ v8.0.0 Sep 26, 2025

Conversation

robertosussex commented Feb 9, 2025

Uh oh!

boegel commented Feb 11, 2025

Uh oh!

robertosussex commented Feb 11, 2025

Uh oh!

robertosussex commented Feb 11, 2025

Uh oh!

robertosussex commented Feb 11, 2025

Uh oh!

robertosussex commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

robertosussex commented Feb 21, 2025 via email

Uh oh!

robertosussex commented Mar 2, 2025

Uh oh!

robertosussex commented Apr 2, 2025

Uh oh!

robertosussex commented Jul 23, 2025

Uh oh!

Thyre commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025 via email

Uh oh!

robertosussex commented Aug 18, 2025 via email

Uh oh!

Thyre commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025

Uh oh!

Thyre commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025 via email

Uh oh!

robertosussex commented Aug 18, 2025 via email

Uh oh!

Thyre commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025 via email

Uh oh!

robertosussex commented Aug 18, 2025 via email

Uh oh!

Thyre commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025 via email

Uh oh!

robertosussex commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025

Uh oh!

Thyre commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025 via email

Uh oh!

boegelbot commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025

Uh oh!

boegelbot commented Aug 18, 2025

Uh oh!

robertosussex commented Aug 18, 2025

Uh oh!

verdurin commented Aug 18, 2025

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

boegel commented Aug 18, 2025

Uh oh!

boegel commented Aug 18, 2025

Uh oh!

Uh oh!