Skip to content

Fix warning in jax 0.3.x that fails the build by using -Wno-maybe-uninitialized#22325

Merged
boegel merged 1 commit intoeasybuilders:5.0.xfrom
Flamefire:20250218090136_new_pr_jax039
Mar 3, 2025
Merged

Fix warning in jax 0.3.x that fails the build by using -Wno-maybe-uninitialized#22325
boegel merged 1 commit intoeasybuilders:5.0.xfrom
Flamefire:20250218090136_new_pr_jax039

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 18, 2025 •
edited
Loading

(created using eb --new-pr)

Not sure why this didn't came up before but I ran into this with jax/0.3.9-foss-2021a while testing easybuilders/easybuild-easyblocks#3557
We have this in 0.4.5 and if it comes up in 0.3.9 it should be safe to fix all of them

Uploading test report for this one EC as the change is the same and only disables a compiler warning so there is IMO no risk of breakage.

@Flamefire Flamefire changed the base branch from develop to 5.0.x February 18, 2025 08:02
@Flamefire Flamefire force-pushed the 20250218090136_new_pr_jax039 branch from 55b8ffe to 93132bc Compare February 18, 2025 08:02
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Feb 18, 2025

Test report by @Flamefire
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3557
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
i7007 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/93aee326068763639dbdafdfd7f8cbbe for a full test report.

@boegel boegel added bug fix and removed change labels Feb 26, 2025
@boegel boegel added this to the 5.0.0 milestone Feb 26, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Feb 26, 2025

@boegelbot please test @ jsc-zen3-a100
EB_BRANCH=5.0.x

@boegel boegel changed the title Fix warning in jax 0.3.x that fails the build Fix warning in jax 0.3.x that fails the build by using -Wno-maybe-uninitialized Feb 26, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 26, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=22325 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_22325 --ntasks=8 --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5795

Test results coming soon (I hope)...

Details

- notification for comment with ID 2684312771 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 26, 2025

Test report by @boegelbot
FAILED
Build succeeded for 9 out of 11 (7 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/da8579c3ff829f33862659c0bf00b34a for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Feb 27, 2025

@boegel NCCL fails with

/usr/include/stdio.h(183): error: attribute "malloc" does not take arguments

Looks like that GCC isn't compatible with that GLibC anymore. Probably needs rebuilding the fix-includes (there is the script in GCCcore installations for that)

@boegel boegel merged commit 66b3a39 into easybuilders:5.0.x Mar 3, 2025
@Flamefire Flamefire deleted the 20250218090136_new_pr_jax039 branch March 4, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @boegel @boegelbot