Skip to content

disable check for RPATH section in git-lfs easyconfigs#22346

Merged
boegel merged 5 commits intoeasybuilders:developfrom
pavelToman:patch-8
May 23, 2025
Merged

disable check for RPATH section in git-lfs easyconfigs#22346
boegel merged 5 commits intoeasybuilders:developfrom
pavelToman:patch-8

Conversation

@pavelToman
Copy link
Copy Markdown
Collaborator

@pavelToman pavelToman commented Feb 20, 2025 •
edited
Loading

Update all relevant git-lfs easyconfigs with check_readelf_rpath variable set to False.
It seems that git-lfs-3.5.1 do not need this fix - it has different build system (not make but go install) and RPATH check is not a problem there.
resolves #17516
resolves vscentrum/vsc-software-stack#502
requires:

@boegel boegel added bug fix and removed change labels Feb 26, 2025
@boegel boegel added this to the 4.x milestone Feb 26, 2025
@boegel boegel self-assigned this May 20, 2025
@pavelToman pavelToman mentioned this pull request May 23, 2025
Closed
2 tasks
@boegel boegel modified the milestones: 5.x, next release (5.1.0) May 23, 2025
@boegel boegel changed the title Add 'check_readelf_rpath' to git-lfs easyconfigs to not check RPATH disable check for RPATH section in git-lfs easyconfigs May 23, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented May 23, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 23, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22346 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22346 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6458

Test results coming soon (I hope)...

Details

- notification for comment with ID 2904841006 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented May 23, 2025

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3502.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/c73443e608ce0529f55995a269424092 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 23, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/e8e2004ffbd46dcb0c72169f7f2ce3e5 for a full test report.

boegel
boegel approved these changes May 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 23, 2025

Going in, thanks @pavelToman!

@boegel boegel merged commit 182d2c3 into easybuilders:develop May 23, 2025
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

@boegel boegel

Labels

bug fix change

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

git-lfs v3.2.0 eb git-lfs-3.2.0.eb --rpath fails on RPATH sanity check

3 participants

@pavelToman @boegel @boegelbot