Skip to content

add patch for astropy 7.0.0 to make one of the tests pass on ARM architectures#22469

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
sara-nl:20250305184801_new_pr_astropy700
Mar 31, 2025
Merged

add patch for astropy 7.0.0 to make one of the tests pass on ARM architectures#22469
verdurin merged 1 commit intoeasybuilders:developfrom
sara-nl:20250305184801_new_pr_astropy700

Conversation

@casparvl
Copy link
Copy Markdown
Contributor

@casparvl casparvl commented Mar 5, 2025 •
edited by boegel
Loading

(created using eb --new-pr)

edit: see also EESSI/software-layer#916

@github-actions github-actions Bot added the change label Mar 5, 2025
@boegel boegel changed the title Patch for making one of the astropy tests pass on ARM architectures add patch for astropy 7.0.0 to make one of the tests pass on ARM architectures Mar 6, 2025
boegel
boegel approved these changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 6, 2025

@boegelbot please test @ jsc-zen3

@boegel boegel added bug fix and removed change labels Mar 6, 2025
@boegel boegel added this to the release after 4.9.4 milestone Mar 6, 2025
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 6, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22469 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22469 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5890

Test results coming soon (I hope)...

Details

- notification for comment with ID 2703027899 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 6, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/4a37ac0341d93eb85452c734bf189115 for a full test report.

@boegel boegel modified the milestones: release after 4.9.4, release after 5.0.0 Mar 18, 2025
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Mar 31, 2025

Test report by @verdurin
SUCCESS
Build succeeded for 4 out of 4 (1 easyconfigs in total)
easybuild-el8.cloud.in.bmrc.ox.ac.uk - Linux Rocky Linux 8.10 (Green Obsidian), x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.8.17
See https://gist.github.com/verdurin/305e7375bc4cc39143488f2b7e72c1c7 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Mar 31, 2025

Going in, thanks @casparvl!

2 similar comments
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Mar 31, 2025

Going in, thanks @casparvl!

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Mar 31, 2025

Going in, thanks @casparvl!

@verdurin verdurin merged commit 2a391f4 into easybuilders:develop Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@casparvl @boegel @boegelbot @verdurin