Skip to content

{base}[foss/2024a] REViewer v0.2.7#22518

Merged
ocaisa merged 11 commits intoeasybuilders:developfrom
asp8200:20250311150943_new_pr_REViewer027
Mar 12, 2025
Merged

{base}[foss/2024a] REViewer v0.2.7#22518
ocaisa merged 11 commits intoeasybuilders:developfrom
asp8200:20250311150943_new_pr_REViewer027

Conversation

@asp8200
Copy link
Copy Markdown
Contributor

@asp8200 asp8200 commented Mar 11, 2025

(created using eb --new-pr)

adding easyconfigs: REViewer-0.2.7-foss-2024a.eb and patches: GraphCo…
c8a803d 
…ordinates.cpp.patch, graph-tools.CMakeLists.txt.patch, reviewer.CMakeLists.txt.patch
@github-actions github-actions Bot added the new label Mar 11, 2025
@asp8200
Copy link
Copy Markdown
Contributor Author

asp8200 commented Mar 11, 2025

I guess this PR needs to be merged first.

ocaisa
ocaisa reviewed Mar 11, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/r/REViewer/REViewer-0.2.7-foss-2024a.eb Outdated
ocaisa
ocaisa requested changes Mar 11, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/r/REViewer/graph-tools.CMakeLists.txt.patch
Comment thread easybuild/easyconfigs/r/REViewer/reviewer.CMakeLists.txt.patch
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Mar 12, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 12, 2025

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22518 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22518 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5917

Test results coming soon (I hope)...

Details

- notification for comment with ID 2717006333 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 12, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/d18acabb3b974c9c37353c6f9d2582d1 for a full test report.

ocaisa
ocaisa approved these changes Mar 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I reshuffled the easyconfig parameters to be in line with the typical (though not enforced) ordering.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Mar 12, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 12, 2025

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22518 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22518 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5918

Test results coming soon (I hope)...

Details

- notification for comment with ID 2717032810 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 12, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/4c2183514a234a35dd537a3db1f74f21 for a full test report.

@ocaisa ocaisa enabled auto-merge March 12, 2025 08:32
@ocaisa ocaisa merged commit e69e4d5 into easybuilders:develop Mar 12, 2025
10 checks passed
@boegel boegel added this to the 5.0.0 milestone Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@asp8200 @ocaisa @boegelbot @boegel