add patch to fix broken test for Siesta v5.2.2 by ocaisa · Pull Request #22562 · easybuilders/easybuild-easyconfigs

ocaisa · 2025-03-14T16:41:35Z

No description provided.

ocaisa · 2025-03-14T16:46:40Z

@boegelbot please test @ jsc-zen3

boegelbot · 2025-03-14T16:50:08Z

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22562 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22562 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 5943

Test results coming soon (I hope)...

Details

- notification for comment with ID 2725224151 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-03-14T17:06:41Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/4bc0a42fa8e9bfcb9e37b8ea879a428b for a full test report.

ocaisa · 2025-03-14T18:00:40Z

@boegelbot please test @ jsc-zen3

boegelbot · 2025-03-14T18:10:08Z

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22562 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22562 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 5944

Test results coming soon (I hope)...

Details

- notification for comment with ID 2725400606 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-03-14T18:10:18Z

Test report by @boegelbot
FAILED
Failed during parsing of the easyconfigs, so no ecs were built (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/a4589a752ac8f9ab5f4cda6e75693155 for a full test report.

migueldiascosta · 2025-03-19T10:41:06Z

@boegelbot please test @ jsc-zen3

boegelbot · 2025-03-19T10:50:09Z

@migueldiascosta: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22562 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22562 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 5999

Test results coming soon (I hope)...

Details

- notification for comment with ID 2736142330 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

…asyconfigs into siesta_5.2.2

boegelbot · 2025-03-19T11:10:55Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/5517741ec05c4520c7e347645d815a25 for a full test report.

migueldiascosta · 2025-03-19T11:19:00Z

hm, building works now, but test_pr_sha256_checksums fails with Checksums missing for one or more sources/patches in Siesta-5.2.2-foss-2023a.eb: found 3 sources + 1 patches vs 1 checksums, probably because the length of the checksums list is 1, the dictionary?

ocaisa · 2025-03-19T14:23:07Z

Yes, it looks like this will require an update in framework.

The problem is https://github.com/easybuilders/easybuild-framework/blob/develop/easybuild/framework/easyblock.py#L2722 ... but checksums are now very complex to count.

ocaisa · 2025-03-20T11:26:19Z

@boegelbot please test @ jsc-zen3

boegelbot · 2025-03-20T11:30:20Z

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22562 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22562 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 6012

Test results coming soon (I hope)...

Details

- notification for comment with ID 2740061236 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2025-03-20T11:50:15Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/da253a0a82f5a1e12809c0b36574d597 for a full test report.

migueldiascosta

lgtm

migueldiascosta · 2025-03-20T14:48:31Z

Going in, thanks @ocaisa!

ocaisa added 2 commits March 14, 2025 17:34

{phys}[foss/2023a] Siesta v5.2.2

679667c

Fix checksums

8a583f6

github-actions Bot added the change label Mar 14, 2025

ocaisa mentioned this pull request Mar 14, 2025

{2023.06}[foss/2023a] Siesta 5.2.2, EasyBuild 5.0.0 EESSI/software-layer#966

Merged

Update Siesta-5.2.2-foss-2023a.eb

ca2dcfc

migueldiascosta reviewed Mar 19, 2025

View reviewed changes

Comment thread easybuild/easyconfigs/s/Siesta/Siesta-5.2.2-foss-2023a.eb Outdated

Merge branch 'develop' of https://github.com/easybuilders/easybuild-e…

1007e3d

…asyconfigs into siesta_5.2.2

Use list of dicts instead of single dict

eba6342

Lines under-indented

5e77a95

migueldiascosta approved these changes Mar 20, 2025

View reviewed changes

migueldiascosta added this to the release after 5.0.0 milestone Mar 20, 2025

migueldiascosta merged commit c47d33c into easybuilders:develop Mar 20, 2025
8 checks passed

boegel changed the title ~~{phys}[foss/2023a] Siesta v5.2.2~~ add patch to fix broken test for Siesta v5.2.2 May 26, 2025

boegel added bug fix and removed change labels May 26, 2025

Conversation

ocaisa commented Mar 14, 2025

Uh oh!

ocaisa commented Mar 14, 2025

Uh oh!

boegelbot commented Mar 14, 2025

Uh oh!

boegelbot commented Mar 14, 2025

Uh oh!

ocaisa commented Mar 14, 2025

Uh oh!

boegelbot commented Mar 14, 2025

Uh oh!

boegelbot commented Mar 14, 2025

Uh oh!

Uh oh!

migueldiascosta commented Mar 19, 2025

Uh oh!

boegelbot commented Mar 19, 2025

Uh oh!

boegelbot commented Mar 19, 2025

Uh oh!

migueldiascosta commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocaisa commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocaisa commented Mar 20, 2025

Uh oh!

boegelbot commented Mar 20, 2025

Uh oh!

boegelbot commented Mar 20, 2025

Uh oh!

migueldiascosta left a comment

Choose a reason for hiding this comment

Uh oh!

migueldiascosta commented Mar 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

migueldiascosta commented Mar 19, 2025 •

edited

Loading

ocaisa commented Mar 19, 2025 •

edited

Loading