Skip to content

use HTTP rather than FTP in source URLs of 'file' easyconfigs#22685

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
boegel:20250401173840_new_pr_file539
Apr 6, 2025
Merged

use HTTP rather than FTP in source URLs of 'file' easyconfigs#22685
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
boegel:20250401173840_new_pr_file539

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 1, 2025 •
edited
Loading

(created using eb --new-pr)

FTP is blocked on some systems, better to avoid it when we can

@github-actions github-actions Bot added the change label Apr 1, 2025
@boegel boegel added this to the release after 5.0.0 milestone Apr 1, 2025
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 1, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--fetch --sourcepath /tmp/$USER/pr22685"

@boegel boegel requested a review from laraPPr April 1, 2025 15:40
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 1, 2025

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22685 EB_ARGS="--fetch --sourcepath /tmp/$USER/pr22685" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22685 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6074

Test results coming soon (I hope)...

Details

- notification for comment with ID 2769796852 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 1, 2025

Test report by @boegelbot
FAILED
Build succeeded for 148 out of 149 (8 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/6cc276ef64eae2ee18e42a6783b0923a for a full test report.

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Apr 1, 2025

Failed for GCCcore-13.3.0.eb
because of another ftp link

== 2025-04-01 15:53:40,382 filetools.py:870 WARNING IOError occurred while trying to download ftp://gcc.gnu.org/pub/gcc/infrastructure/newlib-4.4.0.20231231.tar.gz to /tmp/boegelbot/pr22685/g/GCCcore/newlib-4.4.0.20231231.tar.gz: <urlopen error ftp error: URLError("ftp error: error_perm('550 Failed to change directory.')")>
== 2025-04-01 15:53:40,383 filetools.py:882 INFO Attempt 1 of downloading ftp://gcc.gnu.org/pub/gcc/infrastructure/newlib-4.4.0.20231231.tar.gz to /tmp/boegelbot/pr22685/g/GCCcore/newlib-4.4.0.20231231.tar.gz failed, trying again...

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Apr 1, 2025

Or can I ignore that one since were only doing it for file in this pr?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 2, 2025

Or can I ignore that one since were only doing it for file in this pr?

Looks like a fluke download failure, I see no problems with trying eb --fetch GCCcore-13.3.0.eb locally.

Also, that download issue has nothing to do with the changes in this PR, so it shouldn't block this PR imho.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Apr 5, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--fetch --sourcepath /tmp/$USER/pr22685"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 5, 2025

@SebastianAchilles: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22685 EB_ARGS="--fetch --sourcepath /tmp/$USER/pr22685" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22685 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6117

Test results coming soon (I hope)...

Details

- notification for comment with ID 2781053579 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 5, 2025

Test report by @boegelbot
FAILED
Build succeeded for 148 out of 149 (8 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/7841a6cfd8f34c185d9ae6fc3a23829a for a full test report.

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Apr 6, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--stop fetch --force-download --sourcepath /tmp/$USER/pr22685"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 6, 2025

@SebastianAchilles: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22685 EB_ARGS="--stop fetch --force-download --sourcepath /tmp/$USER/pr22685" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22685 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6121

Test results coming soon (I hope)...

Details

- notification for comment with ID 2781379610 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 6, 2025

Test report by @boegelbot
SUCCESS
Build succeeded for 8 out of 8 (8 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/701466333b7948be77f4fbae39b5d259 for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Apr 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Apr 6, 2025

Going in, thanks @boegel!

@SebastianAchilles SebastianAchilles merged commit 00cb221 into easybuilders:develop Apr 6, 2025
8 checks passed
@boegel boegel added bug fix and removed change labels May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

@laraPPr laraPPr Awaiting requested review from laraPPr

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @boegelbot @laraPPr @SebastianAchilles