Skip to content

Add lsb_release as builddependency to all ABAQUS-2022 easyconfigs#22721

Merged
laraPPr merged 8 commits intoeasybuilders:developfrom
pavelToman:20250407134022_new_pr_ABAQUS2022
Apr 9, 2025
Merged

Add lsb_release as builddependency to all ABAQUS-2022 easyconfigs#22721
laraPPr merged 8 commits intoeasybuilders:developfrom
pavelToman:20250407134022_new_pr_ABAQUS2022

Conversation

@pavelToman
Copy link
Copy Markdown
Collaborator

@pavelToman pavelToman commented Apr 7, 2025 •
edited
Loading

(created using eb --new-pr)
resolves vscentrum/vsc-software-stack#544

@pavelToman pavelToman added the new label Apr 7, 2025
@github-actions github-actions Bot added the change label Apr 7, 2025
@pavelToman pavelToman changed the title add lsb_release dependency Add lsb_release dependency to ABAQUS-2022-hotfix-2214 Apr 7, 2025
@pavelToman pavelToman mentioned this pull request Apr 7, 2025
Closed
2 tasks
boegel
boegel requested changes Apr 7, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/a/ABAQUS/ABAQUS-2022-hotfix-2214.eb Outdated
Comment thread easybuild/easyconfigs/l/lsb_release/lsb_release-2.0.eb Outdated
Comment thread easybuild/easyconfigs/l/lsb_release/lsb_release-2.0.eb Outdated
boegel
boegel reviewed Apr 7, 2025
View reviewed changes
Comment thread easybuild/easyconfigs/l/lsb_release/lsb_release-2.0.eb
@boegel boegel added bug fix and removed change labels Apr 8, 2025
boegel
boegel previously requested changes Apr 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavelToman Can you add lsb_release as build dependency in all three ABAQUS 2022 easyconfigs?

@github-actions github-actions Bot added the change label Apr 8, 2025
@pavelToman pavelToman changed the title Add lsb_release dependency to ABAQUS-2022-hotfix-2214 Add lsb_release as builddependency to all ABAQUS-2022 easyconfigs Apr 8, 2025
@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Apr 9, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 9, 2025

@laraPPr: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22721 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22721 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6139

Test results coming soon (I hope)...

Details

- notification for comment with ID 2789234072 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 9, 2025

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/89dfab7ac95510cd53cac48dc00e414f for a full test report.

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Apr 9, 2025

Test report by @laraPPr
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3551.doduo.os - Linux RHEL 9.4 (Plow), x86_64, AMD EPYC 7552 48-Core Processor, Python 3.9.18
See https://gist.github.com/laraPPr/95378b308db17be10fb6c4fe82499872 for a full test report.

laraPPr
laraPPr requested changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you use local_cimmit and not local_commit?

Comment thread easybuild/easyconfigs/l/lsb_release/lsb_release-2.0.eb Outdated
Comment thread easybuild/easyconfigs/l/lsb_release/lsb_release-2.0.eb Outdated
laraPPr
laraPPr approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Apr 9, 2025

Test report by @laraPPr
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node3551.doduo.os - Linux RHEL 9.4 (Plow), x86_64, AMD EPYC 7552 48-Core Processor, Python 3.9.18
See https://gist.github.com/laraPPr/b893a4c2c9d9145697a5aaa793b58105 for a full test report.

@laraPPr laraPPr dismissed boegel’s stale review April 9, 2025 14:48

Request resolved

@laraPPr laraPPr added this to the release after 5.0.0 milestone Apr 9, 2025
laraPPr
laraPPr approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laraPPr
Copy link
Copy Markdown
Contributor

laraPPr commented Apr 9, 2025

Going in, thanks @pavelToman!

@laraPPr laraPPr merged commit b4b6ee1 into easybuilders:develop Apr 9, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@laraPPr laraPPr laraPPr approved these changes

@boegel boegel boegel left review comments

Assignees

No one assigned

Labels

bug fix change new

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

Abaqus 2022 on RHEL9

4 participants

@pavelToman @laraPPr @boegelbot @boegel