Skip to content

patch Siesta in order to let EasyBuild control optimization flags#22731

Merged
ocaisa merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20250408170727_new_pr_Siesta522
Apr 10, 2025
Merged

patch Siesta in order to let EasyBuild control optimization flags#22731
ocaisa merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20250408170727_new_pr_Siesta522

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

(created using eb --new-pr)

@github-actions github-actions Bot added the change label Apr 8, 2025
@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@migueldiascosta: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22731 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22731 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6137

Test results coming soon (I hope)...

Details

- notification for comment with ID 2787018529 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/1234d312fbaab0dfe09f4fafca369d69 for a full test report.

@migueldiascosta migueldiascosta requested a review from ocaisa April 10, 2025 06:51
ocaisa
ocaisa previously approved these changes Apr 10, 2025
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Apr 10, 2025

@migueldiascosta Given that we now know that -03 was added to all the existing builds, we should decide what to do. Should we add 'opt': True to the toolchainopts? This is also potentially a source of some of the tolerance issues that we have seen.

@migueldiascosta
Copy link
Copy Markdown
Member Author

@migueldiascosta Given that we now know that -03 was added to all the existing builds, we should decide what to do. Should we add 'opt': True to the toolchainopts? This is also potentially a source of some of the tolerance issues that we have seen.

afk, I'll add it later

@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@migueldiascosta: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22731 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22731 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6152

Test results coming soon (I hope)...

Details

- notification for comment with ID 2792312354 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/4727e3d1caf1968811b195d877764f49 for a full test report.

@migueldiascosta migueldiascosta changed the title patch Siesta in order not to override EasyBuild's optarch patch Siesta in order to let EasyBuild control optimization flags Apr 10, 2025
@ocaisa ocaisa merged commit 568990a into easybuilders:develop Apr 10, 2025
8 checks passed
@boegel boegel added bug fix and removed change labels Apr 10, 2025
@boegel boegel added this to the release after 5.0.0 milestone Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants