Skip to content

add patch to avoid OpenCV searching for Python 2#22742

Merged
branfosj merged 1 commit intoeasybuilders:developfrom
Flamefire:20250410122323_new_pr_OpenCV451
Apr 11, 2025
Merged

add patch to avoid OpenCV searching for Python 2#22742
branfosj merged 1 commit intoeasybuilders:developfrom
Flamefire:20250410122323_new_pr_OpenCV451

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Apr 10, 2025 •
edited
Loading

(created using eb --new-pr)

It might find a system python2 which then fails our check in CMakeMake which ensures this doesn't happen.

It is fixed in 4.9 by this: opencv/opencv@212795d

The patch I've made has the same effect for the modified ECs so I kept it.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Apr 10, 2025

@boegel This is a regression in 5.0 failing the build hard, so maybe add to 5.0.1?

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Apr 10, 2025

Test report by @Flamefire
SUCCESS
Build succeeded for 12 out of 12 (5 easyconfigs in total)
i7182 - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/6a9a05a392d740bfc47dfda17fc6d9e7 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 10, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 15 out of 15 (1 easyconfigs in total)
bear-pg0210u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8480CL (sapphirerapids), Python 3.6.8
See https://gist.github.com/branfosj/5db0b68a5ad2fe9f1d793ffe3c4185e3 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 10, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0208u05a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), 1 x NVIDIA NVIDIA A100-SXM4-80GB, 560.35.05, Python 3.6.8
See https://gist.github.com/branfosj/6240af18cbc0f78166fc6c1d5a4ef7e1 for a full test report.

@branfosj branfosj added this to the release after 5.0.0 milestone Apr 10, 2025
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 10, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 22 out of 22 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/ab95b02543b206cd78cadb127d2d9486 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 10, 2025

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
bear-pg0208u05a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), 1 x NVIDIA NVIDIA A100-SXM4-80GB, 560.35.05, Python 3.6.8
See https://gist.github.com/branfosj/8a65766c9ec929ed37b40a8f9b13b064 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Apr 11, 2025

Going in, thanks @Flamefire!

@branfosj branfosj merged commit 852eefb into easybuilders:develop Apr 11, 2025
8 checks passed
@Flamefire Flamefire deleted the 20250410122323_new_pr_OpenCV451 branch April 11, 2025 07:45
@boegel boegel changed the title Avoid OpenCV searching for Python 2 add patch to avoid OpenCV searching for Python 2 May 26, 2025
@boegel boegel added bug fix and removed change labels May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @branfosj @boegel